Bug 1031382

Summary: When creating an "external provider network" in rhevm with vlan tag, the vlan tag disappears from GUI
Product: Red Hat Enterprise Virtualization Manager Reporter: awinter <awinter>
Component: ovirt-engine-webadmin-portalAssignee: Moti Asayag <masayag>
Status: CLOSED CURRENTRELEASE QA Contact: GenadiC <gcheresh>
Severity: high Docs Contact:
Priority: medium    
Version: 3.3.0CC: ecohen, iheim, lvernia, masayag, mkolesni, myakove, rbalakri, Rhev-m-bugs, sherold, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Linux   
Whiteboard: network
Fixed In Version: ovirt-3.5.0_rc1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 17:10:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
No vlan tag on net2
none
engine.log none

Description awinter 2013-11-17 13:58:40 UTC
Description of problem:
When creating an "external provider network" in rhevm with vlan tag, the vlan tag disappears from GUI

Version-Release number of selected component (if applicable):
(rhevm: 3.3.0-0.33.beta1.el6ev)

How reproducible:
100%

Steps to Reproduce:
1. Go to network tab and create an "external provider network" with vlan 164
2. check that network was created but with no vlan tag in the GUI

Actual results:
This network has "-" under the vlan tag 

Expected results:
This network should have "164" under the vlan tag 

Additional info:
When importing a network with vlan tag from a network provider, the vlan IS visible.

Comment 1 awinter 2013-11-17 14:02:03 UTC
Created attachment 825145 [details]
No vlan tag on net2

Comment 2 awinter 2013-11-17 14:03:22 UTC
Created attachment 825146 [details]
engine.log

Comment 3 Mike Kolesnik 2013-11-24 11:04:56 UTC
(In reply to awinter from comment #0)
> Additional info:
> When importing a network with vlan tag from a network provider, the vlan IS
> visible.

I think this behavior should be fixed to "hide" the vlan ID of imported network, since the underlying technology might be gre or vxlan or something else, and basically we don't care what it is when it's managed by oVirt..

So I suggest to change the bug to remove vlan id of imported network.

Comment 4 awinter 2013-11-24 13:35:02 UTC
(In reply to Mike Kolesnik from comment #3)
> (In reply to awinter from comment #0)
> > Additional info:
> > When importing a network with vlan tag from a network provider, the vlan IS
> > visible.
> 
> I think this behavior should be fixed to "hide" the vlan ID of imported
> network, since the underlying technology might be gre or vxlan or something
> else, and basically we don't care what it is when it's managed by oVirt..
> 
> So I suggest to change the bug to remove vlan id of imported network.

When creating a network with vlan via rhevm (at the provider), the network in Neutron is created as vlan and not gre/ vxlan (as far as I know).
As a rhevm user, I would like to know as much as possible from rhevm (I wouldn't want to look in neutron) so even though the network is external, I think that we should present the vlan ID if there is one.

The bug is about creating a new network via rhevm on Neutron, if the user checked vlan ID, I guess he would be happy to see it in the list of networks.

Maybe, *when importing*, we can hide the vlan ID but I'm not sure it is the right approach..

Conclusion: 
* When creating a new network with vlan via *rhevm*, show vlan ID
* When *importing a network* show only if the network is vlan (and not 
  gre/vxlan) OR don't show it at all.

That is my opinion...

Comment 5 Mike Kolesnik 2013-11-24 13:48:54 UTC
(In reply to awinter from comment #4)
> When creating a network with vlan via rhevm (at the provider), the network
> in Neutron is created as vlan and not gre/ vxlan (as far as I know).
> As a rhevm user, I would like to know as much as possible from rhevm (I
> wouldn't want to look in neutron) so even though the network is external, I
> think that we should present the vlan ID if there is one.

Why differentiate between technologies then?

> 
> The bug is about creating a new network via rhevm on Neutron, if the user
> checked vlan ID, I guess he would be happy to see it in the list of networks.
> 
> Maybe, *when importing*, we can hide the vlan ID but I'm not sure it is the
> right approach..
> 
> Conclusion: 
> * When creating a new network with vlan via *rhevm*, show vlan ID
> * When *importing a network* show only if the network is vlan (and not 
>   gre/vxlan) OR don't show it at all.
> 
> That is my opinion...

I think for sake of a level technology playing field the vlan id should be hid from the webadmin, since it can also be random vlan if you dont specify it (depending on plugin).

I think it looks bad as presenting only vlan but not other technology ids...

Comment 6 awinter 2013-11-24 13:56:27 UTC
(In reply to Mike Kolesnik from comment #5)
> (In reply to awinter from comment #4)
> > When creating a network with vlan via rhevm (at the provider), the network
> > in Neutron is created as vlan and not gre/ vxlan (as far as I know).
> > As a rhevm user, I would like to know as much as possible from rhevm (I
> > wouldn't want to look in neutron) so even though the network is external, I
> > think that we should present the vlan ID if there is one.
> 
> Why differentiate between technologies then?
> 
> > 
> > The bug is about creating a new network via rhevm on Neutron, if the user
> > checked vlan ID, I guess he would be happy to see it in the list of networks.
> > 
> > Maybe, *when importing*, we can hide the vlan ID but I'm not sure it is the
> > right approach..
> > 
> > Conclusion: 
> > * When creating a new network with vlan via *rhevm*, show vlan ID
> > * When *importing a network* show only if the network is vlan (and not 
> >   gre/vxlan) OR don't show it at all.
> > 
> > That is my opinion...
> 
> I think for sake of a level technology playing field the vlan id should be
> hid from the webadmin, since it can also be random vlan if you dont specify
> it (depending on plugin).
> 
> I think it looks bad as presenting only vlan but not other technology ids...

I agree but just concern that a rhevm admin will *need* this information.
We can ask for support of gre and vxlan in rhevm but I don't sure it will be done soon, so, like you said, we should probably hide the vlan id and maybe in the future, we will unhide it.

Comment 9 Lior Vernia 2014-04-13 19:41:47 UTC
The behavior as far as I'm aware is currently consistent, with VLAN tag never showing for external networks. Should probably be fixed in the future for all "segmentatio" technologies in OpenStack.

Comment 10 Moti Asayag 2014-07-02 20:24:58 UTC
(In reply to Lior Vernia from comment #9)
> The behavior as far as I'm aware is currently consistent, with VLAN tag
> never showing for external networks. Should probably be fixed in the future
> for all "segmentation" technologies in OpenStack.

Indeed, the vlan-tag is not saved for external networks, hence won't appear for external network created from ovirt-engine or imported from neutron.

Comment 11 GenadiC 2014-07-23 11:04:35 UTC
If you create a new network indeed no VLAN is presented.
But if you import the network the VLAN field is populated with the value
So in order to reproduce the bz just import the network from External provider

Comment 12 GenadiC 2014-08-07 08:36:01 UTC
Verified in  3.5.0-0.0.master.20140804172041.git23b558e.el6

Comment 13 Lior Vernia 2014-11-03 15:34:37 UTC
This requires doc_text only if it's not already made clear somewhere else that Neutron network VLAN-tagging isn't exposed in RHEV.

Comment 14 Eyal Edri 2015-02-17 17:10:54 UTC
rhev 3.5.0 was released. closing.