Bug 1031386

Summary: [engine-webadmin] inappropriate message when trying to perform an operation on a locked disk
Product: Red Hat Enterprise Virtualization Manager Reporter: Elad <ebenahar>
Component: ovirt-engine-webadmin-portalAssignee: Sergey Gotliv <sgotliv>
Status: CLOSED CURRENTRELEASE QA Contact: Leonid Natapov <lnatapov>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: acanan, acathrow, amureini, ecohen, iheim, Rhev-m-bugs, scohen, sgotliv, yeylon
Target Milestone: ---   
Target Release: 3.4.0   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: ovirt-3.4.0-alpha1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1078909, 1142926    
Description Flags
engine.log and screenshot none

Description Elad 2013-11-17 15:35:19 UTC
Created attachment 825162 [details]
engine.log and screenshot

Description of problem:
I tried to deactivate (hotunplug) a disk while it was in locked state (due to previous deactivation). Engine blocked me from doing it with a CanDoAction but on UI I got this message:

"Cannot hot plug Virtual Machine Disk: The following disks are locked: ${diskAliases}. Please try again in a few minutes."

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Deactivate (hotunplug) a disk when the disk is in locked state

Actual results:
On engine.log, I'm getting:

2013-11-17 17:26:11,922 WARN  [org.ovirt.engine.core.bll.HotPlugDiskToVmCommand] (ajp-/ [47da8965] CanDoAction of action HotPlugDiskToVm failed. Reasons:VAR__ACTION__HOT_PLUG,VAR__TYPE__VM_DISK,ACTION_TYPE_FAILED_DISKS_LOCKED

The message on UI is presented with ${diskAliases} instead of the disk alias itself.

Expected results:
We should get the disk alias itself in the error message on UI

Additional info: engine.log and screenshot

Comment 1 Sandro Bonazzola 2014-01-14 08:44:26 UTC
ovirt 3.4.0 alpha has been released

Comment 2 Leonid Natapov 2014-02-16 12:15:18 UTC
3.4.0-0.7.beta2.el6. fixed. deactivate button greyed out while disk is locked.

Comment 3 Itamar Heim 2014-06-12 14:06:52 UTC
Closing as part of 3.4.0