| Summary: | Review Request: datefudge - fakes the system date/time | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nikos Mavrogiannopoulos <nmavrogi> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting, package-review |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | datefudge-1.18-2.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-01 09:31:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Nikos Mavrogiannopoulos
2013-11-18 08:16:19 UTC
First, do you want to support EL5? Hello, I really don't know. Is there a reason for not supporting it? (In reply to Nikos Mavrogiannopoulos from comment #2) > Hello, > I really don't know. Is there a reason for not supporting it? I don't know, but if you don't want to support EL5, you need to remove some lines as modern RPM doesn't need these lines. I don't know which os you are using, but I don't think we need to care about EL5.(Just my opinion) Waiting for your final answer. I have no particular reason to support EL5, so indeed I should drop anything unneeded. Ok.
So:
1. Remove these:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
rm -rf %{buildroot} in %install
Whole %clean
%defattr(-,root,root,-)
2. URL better use PTS page:
http://packages.qa.debian.org/d/datefudge.html
3. Source0 better use CDN:
http://cdn.debian.net/debian/pool/main/d/datefudge/datefudge_1.18.tar.gz
with macro replaced, too.
4. I checked your patch.
INSTALL_PROGRAM := "install" should also be patched to
INSTALL_PROGRAM := "install -p"
5. $(CFLAGS) should be inserted with %{optflags}:
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
You can define cflags like make CFLAGS="%{optflags}"
And $(LDFLAGS) also should be defined with %{__global_ldflags}
Thanks. It's now updated based on your comments. I've uploaded a -2 version. Please paste the new URL. (In reply to Christopher Meng from comment #7) > Please paste the new URL. Spec URL: http://people.redhat.com/nmavrogi/fedora/datefudge.spec SRPM URL: http://people.redhat.com/nmavrogi/fedora/datefudge-1.18-2.fc20.src.rpm datefudge.i686: E: incorrect-fsf-address /usr/share/doc/datefudge/COPYING Please notify upstream about this. ------------- PACKAGE APPROVED. New Package SCM Request ======================= Package Name: datefudge Short Description: fakes the system date/time Owners: nmav Branches: f19 f20 (In reply to Christopher Meng from comment #9) > datefudge.i686: E: incorrect-fsf-address /usr/share/doc/datefudge/COPYING > > Please notify upstream about this. > > ------------- > > PACKAGE APPROVED. Notified, thanks. Git done (by process-git-requests). datefudge-1.18-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/datefudge-1.18-2.fc20 datefudge-1.18-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/datefudge-1.18-2.fc19 datefudge-1.18-2.fc20 has been pushed to the Fedora 20 testing repository. datefudge-1.18-2.fc19 has been pushed to the Fedora 19 stable repository. datefudge-1.18-2.fc20 has been pushed to the Fedora 20 stable repository. |