Bug 1031596

Most (if not all) "General" sub tabs in WebAdmin and UserPortal mix two different kinds of widgets used for rendering values:

a, TextBoxLabel -> border-less <input type="text" readonly> element with added functionality [*]
b, ValueLabel -> span or div element (depending on usage) with no extra functionality
c, classes derived from ValueLabel, i.e. VersionLabel extends ValueLabel<RpmVersion>

[*] Right-clicking the input element causes the element to gain focus and select all text, so that the user can simply choose "Copy" within the context menu.

To make "General" sub tab look & feel more consistent, every (direct or indirect) usage of ValueLabel should be replaced with usage of appropriate TextBoxLabel.

Patch [http://gerrit.ovirt.org/#/c/21289/] introduces support for generic TextBoxLabel widget. All "General" sub tab views (i.e. SubTab{ENTITY}GeneralView) should be reviewed with regard to following changes.

Example 1 - direct usage of ValueLabel:

  operatingSystem = new ValueLabel<Integer>(new AbstractRenderer<Integer>() { ... });

  ... should become ...

  operatingSystem = new TextBoxLabelBase<Integer>(new AbstractRenderer<Integer>() { ... });


Example 2 - indirect usage of ValueLabel:

  VersionLabel libvirtVersion = new VersionLabel();

  public class VersionLabel extends ValueLabel<RpmVersion> {
    public VersionLabel() {
      super(new VersionRenderer());
    }
  }

  ... should become ...

  TextBoxLabelBase<RpmVersion> libvirtVersion = new TextBoxLabelBase<RpmVersion>(new VersionRenderer());

  // VersionLabel is now redundant and can be removed