Bug 1032053

Summary:	Make sure CLI script modules are same on server and CLI zip file
Product:	[JBoss] JBoss Operations Network	Reporter:	Libor Zoubek <lzoubek>
Component:	Build System	Assignee:	RHQ Project Maintainer <rhq-maint>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	high	Docs Contact:
Priority:	high
Version:	JON 3.2	CC:	lkrejci, loleary, myarboro, theute
Target Milestone:	ER07
Target Release:	JON 3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1032201 (view as bug list)		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1032201
Bug Blocks:	1012435

Description Libor Zoubek 2013-11-19 13:16:55 UTC

Description of problem:

I found out JS samples files serverd by JON server http://$JON_SERVER:7080/downloads/script-modules/ differ from JS samples contained in CLI zip file within /samples/modules (for example jbossas.js)

Version-Release number of selected component (if applicable):
JON 3.2.ER5

How reproducible: always


Steps to Reproduce:
1. download CLI client from server, unzip it
2. download jbossas.js sample module from server
3. compare /samples/modules/jbossas.js from CLI zip with the one you got from server

Actual results: files differ


Expected results: files must be same, the same applies for all other JS modules we ship


Additional info: build process should be fixed and use same source dir for those scripts

Comment 1 Lukas Krejci 2013-11-19 17:32:49 UTC

Fixed upstream by BZ 1032201.

Comment 2 Lukas Krejci 2013-11-19 17:34:35 UTC

Note that if this goes into the release branch, BZ 1030958 should be put there, too.

The sample modules in CLI contained a syntax error fixed by BZ 1030958.

Comment 3 Lukas Krejci 2013-11-20 10:51:19 UTC

commit 82679148b096d7e9570dc93a3340b402eed36e84
Author: Lukas Krejci <lkrejci>
Date:   Tue Nov 19 18:31:21 2013 +0100

    [BZ 1032201] - Make sure Server and CLI have the same sample modules
    (cherry picked from commit b6fcca7672bb88c72b8835be628a801598bae68d)

commit 96834ae58c50b0daba09966c0be57d092d0d279c
Author: Lukas Krejci <lkrejci>
Date:   Fri Nov 15 13:29:44 2013 +0100

    [BZ 1030958] - Fixing a syntax error in $CLI/samples/modules/jbossas.js
    (cherry picked from commit a1c65b317d66a05a49befeff95fcc931b785fa9d)

Comment 5 Libor Zoubek 2013-12-05 14:50:05 UTC

verified on CR1