Bug 1032467

+++ This bug was initially created as a clone of Bug #1030437 +++

I am working on a feature that can report state changes using email. For that I need to configure the broker so it can send emails.

I will need the following information:

- smtp server and port
- From email address
- list of To email addresses

The configuration will be in $(engine_ha_confdir)/notifications.conf and will look like this:

[email]
smtp_server=localhost
smtp_port=25
source_email=root@localhost
destination_emails=root@localhost "Martin Sivak <msivak>" "John 'Master' Doe <john>"

There will be other sections in that file as well and those need to be kept intact for now.

--- Additional comment from Sandro Bonazzola on 2013-11-14 08:07:19 EST ---

Didi, can you take care of this? Martin correct me if I'm wrong, this is just a plain ini file parsable by ConfigParser right?
If so I think that multiple values for one key should be separated by ';'
Pay attention in escaping properly " and ' if needed.

--- Additional comment from Yedidyah Bar David on 2013-11-18 04:29:46 EST ---

I recommend to drop the "real name" part and delimit with commas, as is common in sendmail's command line. I also recommend to be very conservative in what chars we accept in email addresses - these are used for notifications and we want them to work also if the mail goes through old/buggy/unconfigured smtp gateways. E.g. allow only something like '[a-zA-Z_.-]+@[a-zA-Z_.-]+' -

destination_emails=root@localhost,admin

Also, do we want to allow to filter sending these emails based on e.g. severity or something like that?

--- Additional comment from Martin Sivák on 2013-11-18 04:42:31 EST ---

We could delimit with commas, I was actually thinking about that. Space was just easier for the initial implementation thanks to shlex :)

But I would like to support real names as we are using them in the email header (From,To) as well. And receiving email from "Hosted engine <root@localhost>" is quite different from just root@localhost.

--- Additional comment from Yedidyah Bar David on 2013-11-18 05:26:01 EST ---

(In reply to Martin Sivák from comment #3)
> We could delimit with commas, I was actually thinking about that. Space was
> just easier for the initial implementation thanks to shlex :)
> 
> But I would like to support real names as we are using them in the email
> header (From,To) as well. And receiving email from "Hosted engine
> <root@localhost>" is quite different from just root@localhost.

I guess that users who care will configure it to be something like 'ovirt-notifications' and point that address to their ticketing system, so that they can reply and track issues. The address does not need to be local, or related to the machine the mail is sent from. I think allowing "real names" will complicate parsing, might lead to new bugs etc., and is not really needed. Most similar notifiers I have used in the past did not allow that either.