Bug 1032523
| Summary: | libbsd: fortify support for string functions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> |
| Component: | libbsd | Assignee: | Eric Smith <spacewar> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | cse.cem+redhatbugz, jgrulich, sam, spacewar |
| Target Milestone: | --- | Keywords: | FutureFeature, Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-19 20:51:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1032518, 1731545 | ||
|
Description
Florian Weimer
2013-11-20 10:54:10 UTC
It is unclear to me how FORTIFY_SOURCE will help strlcpy and wcslcpy, since they are by definition immune to the sort of problems that FORTIFY_SOURCE protects against. I can imagine FORTIFY_SOURCE being useful with other string functions. In any case, is there documentation somewhere on how to add FORTIFY_SOURCE support in cases like this? My searches only turn up how to take advantage of FORTIFY_SOURCE in code that calls string functions, which isn't what I need here. Closing as fixed as the current snapshot trees also don't require nor contain libbsd anymore. opendkim has now a build-requirement on libbsd-devel. (In reply to Eric Smith from comment #2) > It is unclear to me how FORTIFY_SOURCE will help strlcpy and wcslcpy, since > they are by definition immune to the sort of problems that FORTIFY_SOURCE > protects against. I can imagine FORTIFY_SOURCE being useful with other > string functions. We have seen cases where the user-supplied size is incorrect and the compiler knows better. > In any case, is there documentation somewhere on how to add FORTIFY_SOURCE > support in cases like this? My searches only turn up how to take advantage > of FORTIFY_SOURCE in code that calls string functions, which isn't what I > need here. _FORTIFY_SOURCE uses __builtin_object_size from GCC, which is documented in the GCC manual. I'll revive this glibc patch soon. If it is accepted, the definitions can eventually be removed from libbsd: <https://sourceware.org/ml/libc-alpha/2014-09/msg00426.html> This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. Did your strlcpy patch ever make it into glibc, Florian? (In reply to Conrad Meyer from comment #8) > Did your strlcpy patch ever make it into glibc, Florian? Not yet. Still working on it. Any update? Should we patch libbsd to use FORTIFY_SOURCE in the interim? |