Bug 1032673

Summary:	[RFE]“Repo-override” should inform user when adding an override for a non-existing Repo
Product:	Red Hat Enterprise Linux 7	Reporter:	spandey
Component:	subscription-manager	Assignee:	Michael Stead <mstead>
Status:	CLOSED CURRENTRELEASE	QA Contact:	John Sefler <jsefler>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	bkearney, ckozak, kbanerje, mstead, spandey
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-13 12:58:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	863175

Description spandey 2013-11-20 14:57:17 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:
5/5

Prerequisites:
Rhel7 with following subscription-manager rpm 
subscription-manager-gui-1.10.7-1.git.0.15d737b.el7.x86_64
subscription-manager-firstboot-1.10.7-1.git.0.15d737b.el7.x86_64
subscription-manager-migration-1.10.7-1.git.0.15d737b.el7.x86_64
subscription-manager-migration-data-2.0.5-1.git.0.3be2ad4.el7.noarch
subscription-manager-1.10.7-1.git.0.15d737b.el7.x86_64


Steps to Repro :
Register client to candlepin and subscribe instance based subscription 
Override non existing repo using following command 
[root@localhost ~]# subscription-manager repo-override --repo=tesssssssssss –add=test1:123

Expected Result : 
Message should display like 
invalid repoid , --repo=tesssssssssss
invalid Parameters  –add=test1:123

Actual result : 
command successfully executed , No message displayed on console 
[root@localhost yum.repos.d]# subscription-manager repo-override --repo=tesssssssssss --add=test1:123
[root@localhost yum.repos.d]# echo $?
0
[root@localhost yum.repos.d]#

Comment 2 John Sefler 2013-11-20 17:28:50 UTC

In my opinion, adding a repo override to a currently non-existant repo is acceptable and will persist the life of the consumer applying to subscriptions as they are attached and removed.  I believe this is the behavior we want.

However, it can also be misleading to a user that has inadvertantly mistyped a repo name.  I would suggest adding an informative feedback similar to the following mock-up...

# subscription-manager repo-override --repo=foo --repo=bar --add=test1:123
Repository 'foo' does not currently exist, but the override has been added.  
Repository 'bar' does not currently exist, but the override has been added. 
# echo $?
0

Comment 3 Michael Stead 2013-11-21 16:30:21 UTC

I like this idea. I'll work on a fix for this.

Comment 4 Michael Stead 2013-11-28 13:22:44 UTC

https://github.com/candlepin/subscription-manager/pull/828

Comment 6 John Sefler 2013-12-06 17:59:44 UTC

Verifying Version...
[root@jsefler-7 ~]# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: Unknown
subscription-manager: 1.10.8-1.el7
python-rhsm: 1.10.8-1.el7

[root@jsefler-7 ~]# subscription-manager register --serverurl=jsefler-f14-candlepin.usersys.redhat.com:8443/candlepin
Username: testuser1
Password: 
Organization: admin
The system has been registered with ID: 56a31342-9ab1-4185-8917-a641cf7b31c0 
[root@jsefler-7 ~]# subscription-manager repo-override --repo=tesssssssssss --add=test1:123
Repository 'tesssssssssss' does not currently exist, but the override has been added.
[root@jsefler-7 ~]# subscription-manager repo-override --list
Repository: tesssssssssss
  test1: 123

[root@jsefler-7 ~]# 


VERIFIED: When adding a repo-override to a currently non existent repo, the user is informed that the repo does not exist, yet the addition succeeds for future repos.

Comment 7 Ludek Smid 2014-06-13 12:58:48 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.