Bug 1032685

+++ This bug was initially created as a clone of Bug #1031556 +++

Description of problem:
Unexpected MeasurementScheduleRequest with metric name "rhq.availability"

"rhq.availability" should never be passed to #getValues

Version-Release number of selected component (if applicable):
4.9-SNAPSHOT

How reproducible:
Always

Steps to Reproduce:
1.Inventory a Tomcat server
2.Watch the agent logs

Actual results:

Exception thrown because most Tomcat components expect a ":" in the metric name.

2013-11-18 10:20:44,733 ERROR [WorkerThread#0[127.0.0.1:52296]] (rhq.core.pc.measurement.MeasurementManager)- Could not get measurement values
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(String.java:1911)
	at org.jboss.on.plugins.tomcat.TomcatConnectorComponent.getValues(TomcatConnectorComponent.java:137)
	at sun.reflect.GeneratedMethodAccessor63.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.rhq.core.pc.inventory.ResourceContainer$ComponentInvocation.call(ResourceContainer.java:654)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:744)


Expected results:
No exception

--- Additional comment from Thomas Segismont on 2013-11-18 11:44:12 CET ---

It looks like it happens only when you change the availability schedule of a resource.

--- Additional comment from Thomas Segismont on 2013-11-18 18:35:50 CET ---

Eventually found the exact details. These supersede the details from Comment #1

How reproducible:
Always

Steps to Reproduce:
1.Inventory a Tomcat server
2.Navigate to the Monitoring > Metrics tab

Actual results:

Exception thrown because most Tomcat components expect a ":" in the metric name.

2013-11-18 10:20:44,733 ERROR [WorkerThread#0[127.0.0.1:52296]] (rhq.core.pc.measurement.MeasurementManager)- Could not get measurement values
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(String.java:1911)
	at org.jboss.on.plugins.tomcat.TomcatConnectorComponent.getValues(TomcatConnectorComponent.java:137)
	at sun.reflect.GeneratedMethodAccessor63.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.rhq.core.pc.inventory.ResourceContainer$ComponentInvocation.call(ResourceContainer.java:654)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:744)


Expected results:
No exception

Additional info:
This comes from the MetricsViewDataSource#queryResourceMetrics implementation. We query all resource metrics, even those with data type "AVAILABILITY".

--- Additional comment from Thomas Segismont on 2013-11-18 18:38:49 CET ---

commit 9837ddc08e8cd47714ac92c508b707b42acd88bb
Author: Thomas Segismont <tsegismo>
Date:   Mon Nov 18 18:38:02 2013 +0100

When looking for live data, filter measurement definitions to exclude those of data type AVAILABILITY