| Summary: | Review Request: golang-github-syndtr-gocapability - POSIX capability library for the Go programming language | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vincent Batts <vbatts> |
| Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | golang-updates, jkeck, lemenkov, package-review |
| Target Milestone: | --- | Flags: | lsm5:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-02 23:14:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Vincent Batts
2013-11-20 18:05:12 UTC
1. The %{import_path} could be placed in Source0 as well if you wanna make it shorter, but no biggie.
2. rm -rf $RPM_BUILD_ROOT lines should be removed (is it otherwise causing an error on el6?) . Also, I remember you saying absence of %defattr complains on el6, so leaving that in should be ok.
3. as per the prior packaged golang deps, we'd also need:
%dir %attr(755,root,root) %{gopath}/src/github.com
%dir %attr(755,root,root) %{gopath}/src/github.com/syndtr
..in addition to the already existing ones.
4. ls in %install is probably not needed.
1. fair 2. rpmlint noted it. i figured no harm. So i've left it to only the %clean section. 3. added 4. debug leftover. removed. spec: http://vbatts.fedorapeople.org/rpmbuild/SPECS/golang-github-syndtr-gocapability.spec srpm: http://vbatts.fedorapeople.org/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm $ rpmlint ./golang-github-syndtr-gocapability.spec ./golang-github-syndtr-gocapability.spec: W: no-cleaning-of-buildroot %install ./golang-github-syndtr-gocapability.spec: W: no-buildroot-tag 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ fedpkg scratch-build --srpm /home/vbatts/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm Exception AttributeError: '_read_only' in <bound method write.__del__ of <git.config.write object at 0x2600c20>> ignored [====================================] 100% 00:00:00 11.24 KiB 23.09 KiB/sec Building golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm for rawhide Created task: 6207119 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6207119 Watching tasks (this may be safely interrupted)... 6207119 build (rawhide, golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm): open (arm02-builder02.arm.fedoraproject.org) 6207120 buildArch (golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, x86_64): free 6207120 buildArch (golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, x86_64): free -> open (buildvm-22.phx2.fedoraproject.org) 6207121 buildArch (golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, i686): open (buildvm-15.phx2.fedoraproject.org) 6207120 buildArch (golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, x86_64): open (buildvm-22.phx2.fedoraproject.org) -> closed 0 free 2 open 1 done 0 failed 6207121 buildArch (golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, i686): open (buildvm-15.phx2.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 6207119 build (rawhide, golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm): open (arm02-builder02.arm.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 6207119 build (rawhide, golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm) completed successfully approved, but may need revision as and when golang packaging guidelines change New Package SCM Request ======================= Package Name: golang-github-syndtr-gocapability Short Description: POSIX Capability library for the Go programming lanaguage Owners: vbatts Branches: f19 f20 el6 InitialCC: New Package SCM Request ======================= Package Name: golang-github-syndtr-gocapability Short Description: POSIX Capability library for the Go programming lanaguage Owners: vbatts Branches: f19 f20 el6 InitialCC: golang.org spelling corrections in description spec: http://vbatts.fedorapeople.org/rpmbuild/SPECS/golang-github-syndtr-gocapability.spec srpm: http://vbatts.fedorapeople.org/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm $ rpmlint ./golang-github-syndtr-gocapability.spec ./golang-github-syndtr-gocapability.spec: W: no-cleaning-of-buildroot %install ./golang-github-syndtr-gocapability.spec: W: no-buildroot-tag 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ fedpkg scratch-build --srpm /home/vbatts/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm Exception AttributeError: '_read_only' in <bound method write.__del__ of <git.config.write object at 0x2d09c20>> ignored [====================================] 100% 00:00:00 11.30 KiB 27.42 KiB/sec Building golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm for rawhide Created task: 6207211 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6207211 Watching tasks (this may be safely interrupted)... 6207211 build (rawhide, golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm): open (arm02-builder14.arm.fedoraproject.org) 6207213 buildArch (golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, i686): free 6207212 buildArch (golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, x86_64): free 6207212 buildArch (golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, x86_64): free -> open (buildvm-20.phx2.fedoraproject.org) 6207213 buildArch (golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, i686): free -> open (buildvm-24.phx2.fedoraproject.org) 6207213 buildArch (golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, i686): open (buildvm-24.phx2.fedoraproject.org) -> closed 0 free 2 open 1 done 0 failed 6207212 buildArch (golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, x86_64): open (buildvm-20.phx2.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 6207211 build (rawhide, golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm): open (arm02-builder14.arm.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 6207211 build (rawhide, golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm) completed successfully New Package SCM Request ======================= Package Name: golang-github-syndtr-gocapability Short Description: POSIX Capability library for the Go programming language Owners: vbatts Branches: f19 f20 el6 InitialCC: golang-sig Git done (by process-git-requests). golang-github-syndtr-gocapability-0-0.3.git3454319.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-syndtr-gocapability-0-0.3.git3454319.fc20 golang-github-syndtr-gocapability-0-0.3.git3454319.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-syndtr-gocapability-0-0.3.git3454319.fc19 golang-github-syndtr-gocapability-0-0.3.git3454319.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-syndtr-gocapability-0-0.3.git3454319.el6 golang-github-syndtr-gocapability-0-0.3.git3454319.el6 has been pushed to the Fedora EPEL 6 testing repository. golang-github-syndtr-gocapability-0-0.3.git3454319.el6 has been pushed to the Fedora EPEL 6 stable repository. golang-github-syndtr-gocapability-0-0.3.git3454319.fc20 has been pushed to the Fedora 20 stable repository. golang-github-syndtr-gocapability-0-0.3.git3454319.fc19 has been pushed to the Fedora 19 stable repository. golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc22 golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc21 golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc20 golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.el6 golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-github-syndtr-gocapability-0-0.9.git8e4cdcb.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |