Bug 1032765

Summary: running oo-admin-ctl-user without dashes in front of setmaxuntrackedstorage should report syntax error.
Product: OpenShift Online Reporter: Peter Ruan <pruan>
Component: PodAssignee: Rajat Chopra <rchopra>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 2.xCC: jhou
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-24 03:30:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Peter Ruan 2013-11-20 19:30:31 UTC
Description of problem:

running oo-admin-ctl-user without dashes in front of setmaxuntrackedstorage should report syntax error.


Version-Release number of selected component (if applicable):
current.

How reproducible:
always.

Steps to Reproduce:
1. ssh as root in the instance.
2.  oo-admin-ctl-user -l demo setmaxuntrackedstorage 10
3.

Actual results:
[root@broker ~]# oo-admin-ctl-user -l demo setmaxuntrackedstorage 10


User demo:
                            plan: 
                consumed domains: 1
                     max domains: 10
                  consumed gears: 1
                       max gears: 30
    max tracked storage per gear: 0
  max untracked storage per gear: 0
                      gear sizes: small, medium
            sub accounts allowed: false
private SSL certificates allowed: true
              inherit gear sizes: false
                      HA allowed: false


Expected results:

error since the command is missing '--' infront of setmaxuntrackedstorage
Additional info:

Comment 1 Rajat Chopra 2013-11-22 23:01:00 UTC
Fixed with https://github.com/openshift/origin-server/pull/4238

Comment 2 Jianwei Hou 2013-11-25 03:14:47 UTC
Verified on devenv_4067

[root@ip-10-147-131-242 ~]# oo-admin-ctl-user -l jhou  setmaxuntrackedstorage 10
Stray input arguments - ["setmaxuntrackedstorage", "10"]
== Synopsis

oo-admin-ctl-user: Control user settings.

== Notes

  *** WARNING *** WARNING *** WARNING *** WARNING ***

  DO NOT USE THIS SCRIPT TO MODIFY A LOT OF USERS AT ONCE!

  *** WARNING *** WARNING *** WARNING *** WARNING ***

== Usage

oo-admin-ctl-user OPTIONS

Options:
  -l|--login <login_name>
    Login with OpenShift access (required)
  --setmaxdomains <number>
    Set the maximum number of domains a user is allowed to use
  --setmaxgears <number>
    Set the maximum number of gears a user is allowed to use
  --setmaxtrackedstorage <number>
    Set the maximum additional storage per gear that will be tracked for a user
  --setmaxuntrackedstorage <number>
    Set the maximum additional storage per gear that will be untracked for a user
  --setconsumedgears <number>
    Set the number of gears a user has consumed (use carefully)
  --listsubaccounts
    List the subaccounts that have been created under this parent account (login)
  --addsubaccount <subaccount login>
    The sub account to add to the login parent account
  --removesubaccount <subaccount login>
    The sub account to remove from the login parent account
  --allowsubaccounts (true|false)
    Add / Remove the capability to manage sub accounts
  --allowplanupgrade (true|false)
    Add / Remove the capability to upgrade your plan.
  --allowprivatesslcertificates (true|false)
    Add / Remove the capability to add private SSL certificates
  --addgearsize <gearsize>
    Add gearsize to the capability for this login user
  --removegearsize <gearsize>
    Remove gearsize from the capability for this login user
  --inheritgearsizes (true|false)
    Allow / Disallow inheritance of login user gearsizes capability to sub accounts
  --allowha (true|false)
    Allow / Disallow High Availability capability to the user
  -h|--help
    Show Usage info

Examples:
  List the current user settings with:
    oo-admin-ctl-user -l bob

  Set the maximum number of gears a user is allowed to use with:
    oo-admin-ctl-user -l bob --setmaxgears 10
[root@ip-10-147-131-242 ~]# oo-admin-ctl-user -l jhou  --setmaxuntrackedstorage 10


Setting max_untracked_addtl_storage_per_gear to 10... Done.

User jhou:
                            plan: free
                consumed domains: 1
                     max domains: 1
                  consumed gears: 0
                       max gears: 3
    max tracked storage per gear: 0
  max untracked storage per gear: 10
            plan upgrade enabled: true
                      gear sizes: small
            sub accounts allowed: false
private SSL certificates allowed: false
              inherit gear sizes: false
                      HA allowed: false