Bug 1033011

Summary: katello-configure --proxy-url accepts invalid input
Product: Red Hat Satellite Reporter: Justin Sherrill <jsherril>
Component: HammerAssignee: Mike McCune <mmccune>
Status: CLOSED WONTFIX QA Contact: Katello QA List <katello-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.2CC: bbuckingham, bkearney, cwelton, javier.ramirez, sthirugn
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-10-13 12:46:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1025890, 1116898    
Bug Blocks:    

Description Justin Sherrill 2013-11-21 12:16:33 UTC
Description of problem:

if you pass only a fqdn to --proxy-url as part of the installation, everything will go fine but syncing will be broken.  


Version-Release number of selected component (if applicable):
Satellite mdp2

How reproducible:
Always

Steps to Reproduce:
1.  Install katello and only specify an fqdn/hostname to --proxy-url
2.  import a manifest, enable a product & repo, and try to sync one

Actual results:
Failure

Expected results:
Should not be able to pass in just the fqdn/hostnanme to --proxy-url, it should require a proper protocol in the url. (i.e. http://hostname.com/)

Additional info:

Error in /var/log/pulp/nectar.log:
TypeError: sequence item 0: expected string, NoneType found
2013-11-20 20:30:50,497 nectar.downloaders.threaded:ERROR: Unhandled Exception in Worker Thread [140719895340800]
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/nectar/downloaders/threaded.py", line 93, in worker
    session = build_session(self.config)
  File "/usr/lib/python2.6/site-packages/nectar/downloaders/threaded.py", line 282, in build_session
    _add_proxy(session, config)
  File "/usr/lib/python2.6/site-packages/nectar/downloaders/threaded.py", line 312, in _add_proxy
    url = ':'.join((host, str(config.proxy_port)))

Comment 1 RHEL Program Management 2013-11-21 12:42:26 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 6 Corey Welton 2014-06-03 19:24:59 UTC
bouncing to 6.0.4

Comment 7 Bryan Kearney 2015-10-13 12:46:53 UTC
katello-configure is no longer shipped, and the new installer has undergone substantial testing on proxies. Closing this out.