Bug 1033053

Summary: [horizon] hover hints for instance:<type> meters are missing
Product: Red Hat OpenStack Reporter: Eoghan Glynn <eglynn>
Component: python-django-horizonAssignee: Eoghan Glynn <eglynn>
Status: CLOSED ERRATA QA Contact: Nir Magnezi <nmagnezi>
Severity: low Docs Contact:
Priority: medium    
Version: 4.0CC: aortega, breeler, ddomingo, eglynn, hateya, jpichon, mrunge, yeylon
Target Milestone: rcKeywords: Triaged
Target Release: 4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-django-horizon-2013.2-6.el6ost Doc Type: Bug Fix
Doc Text:
The Dashboard service now retrieves the list of supported flavors from the nova-api service before constructing hover hints for the Metric drop-down list (in the admin/Resource Usage panel). The nova-api service provides correct and updated hover hints for all items that appear in this drop-down list, including the generic "instance:<type>" entry. In previous releases, this entry did not have a hover hint.
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-20 00:37:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Eoghan Glynn 2013-11-21 13:32:27 UTC
Description of problem:

The Metric dropdown list on the Stats tab of the admin/Resource Usage panel has hover hints with a short description of each meter listed.

However the hover hint for instance:<type> meter is missing.

This is because tab context_data list of hover hints is seemingly built up from a copy'n'paste from the ceilometer documentation:

  http://docs.openstack.org/developer/ceilometer/measurements.html#compute-nova

in particular, using the literal 'instance:<type>' as the meter name.

Whereas in the ceilometer docco, 'instance:<type>' is not intended to be interpreted as a literal meter name. Instead the '<type>' is intended to act as a placeholder for the actual instance type, i.e. the nova flavor name of 'm1.tiny', 'm1.small', etc.

So this non-existent 'instance:<type>' meter should be replaced with a set of hints for meters named with a 'instance:' prefix and a flavor name suffix, for each of the current set of flavors known to nova (i.e. both standard and custom instance types).


Version-Release number of selected component (if applicable):

RHOS 4.0 beta


How reproducible:

100%


Steps to Reproduce:

1. Ensure an instance is spun up

2. Navigate to the admin/Resource Usage panel 

3. Hover over the 'instance:<type>' entry in the Metric dropdown and note the lack of a hover hint

4. Hover over any other meter and note the existence of a hover hint


Actual results:

No hover hint for 'instance:<type>' in the Metric dropdown


Expected results:

A hover hint for 'instance:<type>' is displayed

Comment 1 Eoghan Glynn 2013-11-21 13:35:14 UTC
Fix landed on upstream master:

  http://github.com/openstack/horizon/commit/386d5865

and proposed on upstream stable/havana:

  https://review.openstack.org/54709

Comment 3 Eoghan Glynn 2013-11-28 12:04:06 UTC
Fix landed on stable/horizon upstream:

  http://github.com/openstack/horizon/commit/9be1df13

Comment 4 Eoghan Glynn 2013-11-28 12:06:17 UTC
Backport landed internally:

  https://code.engineering.redhat.com/gerrit/16395

Note the commit message contains an erroneous tag:

 s/Resolves rhbz: 1033044/Resolves rhbz: 1033053/

(similar BZ IDs and bug subject matter led to this human error on my part)

Comment 6 Nir Magnezi 2013-12-05 10:23:38 UTC
Will Test this fix as soon as QE will get a build newer than 2013-11-26.3

Comment 8 Julie Pichon 2013-12-11 10:05:09 UTC
Hi Don, thank you for the doc text beautification in this and other bugs! I would suggest removing the last sentence, "In previous releases, this entry did not have a hover hint." as this is a new panel.

Comment 9 Eoghan Glynn 2013-12-11 10:35:24 UTC
Hi Don, also the beautified text is slightly incorrect, specifically:

... including the generic "instance:<type>" entry.

The point of the fix was to replace the generic "instance:<type>" entry with the specific "instance:m1.tiny", "instance:m1.small", "instance:m1.medium" ... etc. meter names that actually exist in the metering store.

Also:

"The nova-api service provides correct and updated hover hints ..."

is a bit misleading. The nova-api service provides the existing flavor names (i.e. instance types) only. Horizon then constructs a hover hit around the flavor name, e.g. in the hover hint:

'Duration of instance type m1.tiny (openstack flavor)'

only the 'm1.tiny' portion is provided by the nova-api service.

Comment 10 Nir Magnezi 2013-12-16 10:12:23 UTC
Verified NVR: python-django-horizon-2013.2-8.el6ost.noarch

Repeated the steps to reproduce in comment #0

Result:
=======
When I hovered the 'instance:<type>' attribute, a hint was displayed:

Duration of instance <type> (openstack types)

Comment 12 errata-xmlrpc 2013-12-20 00:37:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2013-1859.html