Bug 1033116

Summary: wrong exit code (code of 0) when exit status of 5 expected.
Product: Red Hat Enterprise Linux 7 Reporter: smatula
Component: PackageKitAssignee: Richard Hughes <rhughes>
Status: CLOSED WONTFIX QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: mclasen
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-12 15:50:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description smatula 2013-11-21 15:09:46 UTC 
Description of problem:
When running pkcon in the following situations. Command is executed but actual result is of none or nothing is needed to be done. Expected a return code of 5 -  'Nothing useful was done.' But a status of 0 is returned.

pkcon repo-enable  a already enabled repo.
pkcon repo-disable a already disabled repo.
pkcon get-depends setup   (no depends - no results)
pkcon get-requires mc     (no requires - no results)


Version-Release number of selected component (if applicable):
PackageKit-0.8.9-8.el7

How reproducible:
always

Steps to Reproduce:
1. open terminal
2. Run one of the 4 commands (scenarios listed above)
3. 

Actual results:
Exit status code of 0

Expected results:
Exit status code of 5

Additional info:
Comment 2 Richard Hughes 2013-11-22 10:26:34 UTC 
(In reply to smatula from comment #0)
> pkcon repo-enable  a already enabled repo.
> pkcon repo-disable a already disabled repo.

This probably should return exit code 5, although isn't a huge problem IMO.

> pkcon get-depends setup   (no depends - no results)
> pkcon get-requires mc     (no requires - no results)

These are tasks, and so we never perform an action. It's probably correct to say that by showing no results the return code is success, i.e. we showed the user what they wanted to see. This should return 0 on success always.

Richard.
Comment 3 Matthias Clasen 2013-12-12 03:24:48 UTC 
we're not going to get pkcon fixes for 7.0. yum is the recommended commandline client for software installation, anyway
Comment 4 RHEL Program Management 2013-12-12 15:50:13 UTC 
Development Management has reviewed and declined this request.
You may appeal this decision by reopening this request.