Bug 1033119

Summary:	Incorrect bundle destination is chosen in deploy-to-and-restart-JBAS.js sample file
Product:	[JBoss] JBoss Operations Network	Reporter:	Filip Brychta <fbrychta>
Component:	CLI	Assignee:	RHQ Project Maintainer <rhq-maint>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	JON 3.2	CC:	lkrejci
Target Milestone:	CR01
Target Release:	JON 3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-02 20:34:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Filip Brychta 2013-11-21 15:19:08 UTC

Description of problem:
Here is the problem:
<code>
    var destinationId = jbasDestination;
    if (typeof(jbasDestination) == 'object') {
        destinationId = jbasDestination.id;
    }

    var destCrit = new BundleDestinationCriteria
    destCrit.fetchGroup(true)

    var destinations = BundleManager.findBundleDestinationsByCriteria(destCrit);
</code>

Used destCrit doesn't have FilterId set. So the findBundleDestinationsByCriteria function then finds first destination which could be incorrect.

Correct version:
<code>
    var destinationId = jbasDestination;
    if (typeof(jbasDestination) == 'object') {
        destinationId = jbasDestination.id;
    }

    var destCrit = new BundleDestinationCriteria
    destCrit.fetchGroup(true)
    destCrit.addFilterId(destinationId);

    var destinations = BundleManager.findBundleDestinationsByCriteria(destCrit);
</code>

Version-Release number of selected component (if applicable):
Jon3.2.ER5 and master as well:
Version :	
4.10.0-SNAPSHOT
Build Number :	
cb5f098

Comment 1 Filip Brychta 2013-11-21 15:46:39 UTC

The same problem is in jbossas module

Comment 2 Lukas Krejci 2013-11-21 20:49:40 UTC

Note that this was fixed POST ER7.

commit 3217afa463913656a1e0af3b58b27a782f55d472
Author: Lukas Krejci <lkrejci>
Date:   Thu Nov 21 21:41:06 2013 +0100

    [BZ 1033119] Find the asked for destination, not just a random one in
    deploy-to-and-restrart-JBAS.js#updateAppAndRestartJBAS(),
    require("modules:/jbossas").updateAppAndRestart()

Comment 3 Simeon Pinder 2013-12-03 23:19:37 UTC

Moving to ON_QA for testing in latest(CR1) brew build.

Comment 4 Filip Brychta 2013-12-04 08:55:27 UTC

Verified on:
Version :	
3.2.0.CR1
Build Number :	
6ecd678:d0dc0b6