Bug 1033249

Summary: Error encountered when executing neutron::networking host group on a host
Product: Red Hat OpenStack Reporter: james labocki <jlabocki>
Component: openstack-foreman-installerAssignee: Jason Guiditta <jguiditt>
Status: CLOSED ERRATA QA Contact: Ofer Blaut <oblaut>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0CC: breeler, cwolfe, dcleal, hateya, jguiditt, jstransk, mlopes, morazi, rhos-maint, sreichar, yeylon
Target Milestone: rcKeywords: OtherQA
Target Release: 4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-foreman-installer-0.0.23-1.el6ost Doc Type: Enhancement
Doc Text:
With this update, OVS bridge name and associated IP values are no longer hardcoded assumptions. OVS bridges can now be renamed, and IP association is now optional.
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-20 00:38:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1039278    

Description james labocki 2013-11-21 18:58:56 UTC
Issues with interface setup when deploying neutron::networking

    Error: Could not set 'present' on ensure: Undefined IP address at 30:/usr/share/openstack-foreman-installer/puppet/modules/quickstack/manifests/neutron/networker.pp

    Error: Could not set 'present' on ensure: Undefined IP address at 30:/usr/share/openstack-foreman-installer/puppet/modules/quickstack/manifests/neutron/networker.pp

    Wrapped exception:

    Undefined IP address

    Error: /Stage[main]/Quickstack::Neutron::Networker/Vs_port[external]/ensure: change from absent to present failed: Could not set 'present' on ensure: Undefined IP address at 30:/usr/share/openstack-foreman-installer/puppet/modules/quickstack/manifests/neutron/networker.pp

Comment 1 james labocki 2013-11-21 19:00:45 UTC
    We had to set an ip address manually on the bridge interface to get this to work.

    DEVICE=eth1

    HWADDR=00:1A:64:76:00:15

    TYPE=Ethernet

    UUID=16926dcf-a379-417c-97ae-fccafa194c0c

    ONBOOT=yes

    NM_CONTROLLED=no

    BOOTPROTO=static

    IPADDR=10.16.136.180

Comment 3 Jason Guiditta 2013-11-21 20:09:32 UTC
As discussed during this testing, this looks to me to be two things:

1. Lack of clarity in docs.  The assumption this code currently makes is that the user already has an IP on the NIC to be configured as an ovs bridge, so when the port is added it woudl fail when no IP is present.

2. More configuration needed to allow for no ip to be needed. Currently, we have:
vs_port { 'external':
            bridge    => 'br-ex',
            interface => $public_interface,
            keep_ip   => true,
            sleep     => '30',
            provider  => ovs_redhat,
            ensure    => present,
        }
As you can see, both bridge and keep_ip values are hard-coded.  If we make those configurable (especially keep_ip), I believe this issue goes away.

Comment 4 Mike Orazi 2013-11-22 22:15:30 UTC
Jason,

Can you the params from #2 into your next build?

Comment 5 Jason Guiditta 2013-11-22 23:32:54 UTC
Yep, I'll add these on monday, and whenever we push the next rpm, they will be there.

Comment 6 Jason Guiditta 2013-11-25 21:49:26 UTC
*** Bug 1028621 has been marked as a duplicate of this bug. ***

Comment 7 Jiri Stransky 2013-11-29 16:29:32 UTC
Puppet applied fine for me using packstack-modules-puppet version 2013.2.1-0.15.dev847.el6 with current upstream astapor master (commit 7143de6600). I did a 3 node setup: controller, networker, compute.

Comment 8 Jason Guiditta 2013-12-02 19:39:37 UTC
Posted: https://github.com/redhat-openstack/astapor/pull/60

Comment 9 Jason Guiditta 2013-12-03 22:18:43 UTC
https://github.com/redhat-openstack/astapor/pull/62

make the new vars so they can be overridden by default

Comment 12 Crag Wolfe 2013-12-18 22:23:39 UTC
Verified that bridge_name and bridge_keep_ip appear as parameters that can be overidden in Foreman UI by clicking More->Configuration->Host Groups, Neutron Networker, the Parameters tab.

Comment 15 errata-xmlrpc 2013-12-20 00:38:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2013-1859.html