Bug 1033365

Reworked the behavior while working on "smart activation keys"  There have probably been some other changes since the stage build as well.  For instance, default quantity on future subscriptions uses the date that it begins rather than today.

commit a121556d1039400c483d8414fcdb1f5374f31df6
Author: ckozak <ckozak>
Date:   Wed Oct 23 15:00:53 2013 -0400

    ActKeys can take null quantity, pick quantity upon activation

Comment 1 addresses a different issue.
Flipping back to NEW as this bug is simply requesting a string change.

Your suggestion is an improvement John, but perhaps we could streamline it a bit more?

This seems a little cleaner to me:
"Attach failed, this subscription must be attached in increments of '<$INSTANCE_MULTIPLIER>'."

I'd rather not encourage people to attempt mental math if we can avoid it :) Saying "in increments of 2" tells me that I have to say 2, 4, 6, etc, but I'd be curious if it sounds reasonable to others. Also, its very specific that their last request failed and gives them context why, hopefully letting them update their quantity and fix their problem.

If they just specified the pool, do you think it's worthwhile to list the subscription name? Our names can be pretty huge, if it's something they probably just looked up, I'd lean towards not cluttering up the error message with the name, especially since given our naming, it's probably not even likely to indicate a type difference in the name. 

What do you think? Better? Worse?

We do need to print out the subscription name.  Here's an example why...

[root@jsefler-7server ~]# subscription-manager attach --quantity 1 --pool 8a99f9844228f57b014233437f345c4d --pool 8a99f9844228f57b0142334889e65cc4 --pool 8a99f9844228f57b0142334d24145d06 --pool 8a99f9844228f57b0142334975185cde --pool 8a99f9844228f57b0142334d243f5d17 --pool 8a99f9844228f57b01423348142a5cac --pool 8a99f9844228f57b01423347ab895c98 --pool 8a99f9844228f57b01423347ab6b5c85
Successfully attached a subscription for: Red Hat Enterprise Linux Server Beta
Successfully attached a subscription for: Red Hat Enterprise Linux Desktop Beta
Successfully attached a subscription for: All Add-on Beta
Successfully attached a subscription for: Red Hat Enterprise Linux Workstation Beta
Successfully attached a subscription for: Red Hat Enterprise Linux 7 High Touch Beta
Quantity '1' is not a multiple of instance multiplier '2'
Quantity '1' is not a multiple of instance multiplier '2'
Quantity '1' is not a multiple of instance multiplier '2'
[root@jsefler-7server ~]# 

When attaching multiple subscriptions from the command line, we don't know which subscriptions failed to attach.  Notice that we give feedback for the successfully attached subscription name, but not the failed attachment.  How about this message:

Failed to attach subscription '<$NAME>'. It must be attached in increments of '<$INSTANCE_MULTIPLIER>'.

That's what I was afraid of... in that case, I agree we have to show names. I like that message.

Is that subscription name in the success message or product name?

I'm afraid to say a subscription must be attached in increments of 2 because it sounds like I'd need to attach quantity 2 three times if I really need quantity 6.

Writing a patch that uses the original language John suggested.

Candlepin commit e7e709f2f5ae255cf12379fa6d7e974d462329e4

    1033365: Added cleaner instance multiplier exception message

Verifying Version...
[root@jsefler-7 ~]# subscription-manager version
server type: Red Hat Subscription Management     <======= candlepin-0.9.3
subscription management server: Unknown
subscription-manager: 1.10.14-3.el7
python-rhsm: 1.10.12-1.el7


[root@jsefler-7 ~]# subscription-manager register --username=rhel7beta --serverurl=subscription.rhn.stage.redhat.com:443/subscription
Password: 
The system has been registered with ID: aa406244-4a06-4cd3-9d1f-83a4af13eeb5 
[root@jsefler-7 ~]# subscription-manager  list --available | egrep "Subscription Name:|Pool ID:|Suggested:"
Subscription Name: Red Hat Enterprise Linux Server Beta
Pool ID:           8a99f9844228f57b014233437f345c4d
Suggested:         4
Subscription Name: Red Hat Enterprise Linux Desktop Beta
Pool ID:           8a99f9844228f57b0142334889e65cc4
Suggested:         8
Subscription Name: All Add-on Beta
Pool ID:           8a99f9844228f57b0142334d24145d06
Suggested:         4
Subscription Name: Red Hat Enterprise Linux Workstation Beta
Pool ID:           8a99f9844228f57b0142334975185cde
Suggested:         4
Subscription Name: Red Hat Enterprise Linux 7 High Touch Beta
Pool ID:           8a99f9844228f57b0142334d243f5d17
Suggested:         4
Subscription Name: Red Hat Enterprise Linux Server Beta for HPC Compute Node
Pool ID:           8a99f9844228f57b01423348142a5cac
Suggested:         2
[root@jsefler-7 ~]# subscription-manager subscribe --pool=8a99f9844228f57b014233437f345c4d --pool=8a99f9844228f57b0142334889e65cc4 --pool=8a99f9844228f57b0142334d24145d06 --pool=8a99f9844228f57b0142334975185cde --pool=8a99f9844228f57b0142334d243f5d17 --pool=8a99f9844228f57b01423348142a5cac --quantity=1
Subscription 'Red Hat Enterprise Linux Server Beta' must be attached using a quantity evenly divisible by 2
Subscription 'Red Hat Enterprise Linux Desktop Beta' must be attached using a quantity evenly divisible by 2
Subscription 'All Add-on Beta' must be attached using a quantity evenly divisible by 2
Subscription 'Red Hat Enterprise Linux Workstation Beta' must be attached using a quantity evenly divisible by 2
Subscription 'Red Hat Enterprise Linux 7 High Touch Beta' must be attached using a quantity evenly divisible by 2
Subscription 'Red Hat Enterprise Linux Server Beta for HPC Compute Node' must be attached using a quantity evenly divisible by 2
[root@jsefler-7 ~]# 

VERIFIED: The failure message to attach instance-based subscriptions with an odd quantity is now much friendly.

These bugs were fixed during 7.0 but not moved to CLOSED. They have been delivered