Bug 1033403

Summary: Wrong notification shown for settings update after removing a language
Product: [Retired] Zanata Reporter: Damian Jansen <djansen>
Component: Component-UIAssignee: Alex Eng <aeng>
Status: CLOSED CURRENTRELEASE QA Contact: Damian Jansen <djansen>
Severity: medium Docs Contact:
Priority: unspecified    
Version: developmentCC: aeng, zanata-bugs
Target Milestone: ---   
Target Release: 3.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-18 06:48:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Screenshot none

Description Damian Jansen 2013-11-22 03:34:12 UTC 
Description of problem:
If the group maintainer removes a language, then updates some general settings, the success notification shown for updating the settings is the "Language x has been removed from the group"

Version-Release number of selected component (if applicable):
dev

How reproducible:
Moderate, always

Steps to Reproduce:
1. Sign in as admin, go to Groups
2. Select / Create a group
3. If the group has no set languages, add one (Click settings, languages, Add)
4. In Settings -> Languages, remove a group
5. Go to Settings -> General
6. Press Update general settings

Actual results:
Notification: "Language 'French' has been removed from group."

Expected results:
Notification: "Successfully updated"

Additional info:
It seems the correct notification is shown, but only for a fraction of a second before showing the wrong one
Comment 1 Alex Eng 2013-11-22 06:30:05 UTC 
Pull request:
https://github.com/zanata/zanata-server/pull/287

Commit:
https://github.com/zanata/zanata-server/commit/4506dfae09aa0909467a796791dab6a843be3ecc
Comment 2 Alex Eng 2013-11-24 21:35:37 UTC 
commit:
https://github.com/zanata/zanata-server/commit/df0ef3f78d7036964a1a07766840d61b9530f951
Comment 3 Alex Eng 2013-11-24 22:04:22 UTC 
The expected results when add/removing locale should be:
"Language 'French' has been add/removed from group."

"Successfully updated" is a generic message return from server when entity is updated.
Comment 4 Damian Jansen 2013-11-25 03:59:26 UTC 
Created attachment 828499 [details]
Screenshot

Is this a valid notification scenario?

i.e. I removed the language French, then renamed the group. The Add/Remove notification didn't go away.
Comment 5 Alex Eng 2013-11-25 04:52:28 UTC 
Pull request:
https://github.com/zanata/zanata-server/pull/294
Comment 6 Damian Jansen 2013-11-26 03:10:14 UTC 
Verified at 19c23e1a933e97cb309638a92053d139f26fedd0