Bug 1033445

Summary:	[origin_broker_169] Enable ALLOW_DEPRECATED_CARTRIDGES does not get deprecated cartridge re-usable.
Product:	OpenShift Online	Reporter:	Liang Xia <lxia>
Component:	Pod	Assignee:	Lili Nader <lnader>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	mfisher, xtian
Target Milestone:	---	Keywords:	UpcomingRelease
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-24 03:34:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Liang Xia 2013-11-22 06:24:32 UTC

Description of problem:
Setting ALLOW_DEPRECATED_CARTRIDGES="true" in broker-dev.conf, deprecated cartridges still not usable.

Version-Release number of selected component (if applicable):
devenv_4061

How reproducible:
always

Steps to Reproduce:
1.SSH into an instance and run "rhc cartridge list" to show the cartridges avaliable.
2.Set ALLOW_DEPRECATED_CARTRIDGES="false" in broker-dev.conf
3.Add "Deprecated: true" to some cartridges' manifest.yml ( like mysql-5.1, python-2.7, python-3.3 ) under folder /usr/libexec/openshift/cartridges/*/metadata/
4.Clear broker cache and restart broker/mcollective service.
5.Run "rhc cartridge list" to show the cartridges avaliable.
6.Set ALLOW_DEPRECATED_CARTRIDGES="true" in broker-dev.conf
7.Clear broker cache and restart broker/mcollective service.
8.Run "rhc cartridge list" to show the cartridges avaliable.
9.Create app with the deprecated cartridge.
rhc app create py27 python-2.7 mysql-5
10.Create app with the deprecated cartridge.
rhc app create py26 python-2.6 mysql-5
11.Add the deprecated cartridge to an app.
rhc cartridge add mysql-5 -a php

Actual results:
Step 1 show all cartridges.
Step 5 show cartridges excluding mysql-5, python-2.7, python-3.3.
Step 8 show cartridges excluding mysql-5, python-2.7, python-3.3.
Step 9 show "There are no cartridges that match 'python-2.7'"
Step 10 show "There are no cartridges that match 'mysql-5'."
Step 11 show "There are no cartridges that match 'mysql-5'."

Expected results:
Step 8 should show all cartridges ( deprecated and non-deprecated ) as broker has allowed deprecated cartridges.
Step 9/10/11 should successful.

Additional info:

Comment 1 Abhishek Gupta 2013-11-22 18:01:07 UTC

Marking this an UpcomingRelease. We are still dealing with blockers for 2.0.36.

Comment 2 Lili Nader 2013-11-22 21:10:49 UTC

Fixed the rhc cartridge list issue

https://github.com/openshift/origin-server/pull/4237

Also renamed deprecated to obsolete

Comment 4 Liang Xia 2013-11-26 05:36:19 UTC

Verified on devenv_4071.

The obsolete cartridges were hiden from rhc/UI/RESTAPI when ALLOW_OBSOLETE_CARTRIDGES="false", and got show again when true.

Comment 5 Liang Xia 2013-11-26 05:37:25 UTC

Updated the cases.