Bug 1033453

Summary: Build error on kie-wb-distributions/kie-wb-distribution-home
Product: [Retired] JBoss BPMS Platform 6 Reporter: Ryan Zhang <rzhang>
Component: Build and AssemblyAssignee: Neus Miras <nmirasch>
Status: CLOSED CURRENTRELEASE QA Contact: Marek Baluch <mbaluch>
Severity: unspecified Docs Contact:
Priority: high    
Version: 6.0.0   
Target Milestone: ER6   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:12:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
build.patch none

Description Ryan Zhang 2013-11-22 06:45:36 UTC
Description of problem:
This is a small error on build kie-wb-distributions. kie-wb-distribution/kie-distribution-home pom's parent locate in the sibbling folder instead of uppper folder.  So a relativePath is required in <parent>...</parent> section.

This problem will be able to reproduced by running 'mvn dependency:resolve-plugins 'if not using snapshot and a clean local repo.

I think the following patch is required for the build(Also attached):

diff --git a/kie-wb-distribution-home/pom.xml b/kie-wb-distribution-home/pom.xml
index 045badb..7e1aae2 100644
--- a/kie-wb-distribution-home/pom.xml
+++ b/kie-wb-distribution-home/pom.xml
@@ -5,6 +5,7 @@
         <groupId>org.kie</groupId>
         <artifactId>kie-wb</artifactId>
         <version>6.0.0-SNAPSHOT</version>
+        <relativePath>../kie-wb/pom.xml</relativePath>
     </parent>
   <modelVersion>4.0.0</modelVersion>

Version-Release number of selected component (if applicable):
Tag: sync.2013.11.19

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Ryan Zhang 2013-11-22 06:49:01 UTC
Created attachment 827597 [details]
build.patch

Comment 3 Edson Tirelli 2013-11-22 15:23:13 UTC
Pedro, can you check who on your team is working on this? I think it is Neus.

Also, I suggest he talks to Geoffrey to understand if there is a better way of integrating this into the whole build structure. Since this module only exists in the product, not in the community, I am afraid that the current way it is setup might cause us problems in the future due to the fact that this module is not listed in the BOMs and parent POMs. Geoffrey is the best person to talk to about it.

Comment 4 Pedro Zapata 2013-11-22 15:38:19 UTC
- The patch needs no be applied to the branding branch (if not already).
- Discuss with Geoffrey and Michael possible implications in future builds, and discuss alternative solutions to keep track of this module in community builds).

Comment 5 Neus Miras 2013-11-25 11:34:07 UTC
I changed the parent id artifact from kie-wb (needs relative path to ve referenced) to kie-distributions (that is just in a upper level.

Commit:

rep: jboss-integration / kie-wb-distributions
branch: branding.2013.11.15
commit link: https://github.com/jboss-integration/kie-wb-distributions/commit/2afd44c7db26e2042681583f837a1f7e2d6001c7

Comment 6 Neus Miras 2013-11-26 14:40:21 UTC
Added pluggins to use anotations to include homePerspective.

Commit:
rep: jboss-integration / kie-wb-distributions
branch: branding.2013.11.15
https://github.com/jboss-integration/kie-wb-distributions/commit/afe4db75cec934898fcbc2cfb59546bb103b5af8

Comment 7 Marek Baluch 2013-12-20 14:30:31 UTC
The fact that we have a build should be sufficient proof that this is fixed.

Verified on ER6.