Bug 1033481

Summary:	Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing
Product:	[Fedora] Fedora	Reporter:	Mathieu Bridon <bochecha>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bochecha, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-15 09:04:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1034017
Bug Blocks:	1033494

Description Mathieu Bridon 2013-11-22 08:28:59 UTC

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time-0.04-1.fc20.src.rpm

Description:
Test::Time can be used to test modules that deal with time. Once you use
this module, all references to time and sleep will be internalized. You can
set custom time by passing time => number after the use statement:

Fedora Account System Username: bochecha

Comment 1 Petr Šabata 2013-11-22 11:42:22 UTC

FIX: The buildtime dependency list is incorrect.

The package bundles most of the modules needed for build in inc/.  Not all of them, though.  You could:
- either remove them and use those provided by Fedora, 
- or list the dependencies not included in the budle but required by the used bundled modules.

This applies to both Test::* and inc::Module::Install.
However, Test::Name::FromLine doesn't appear to be in Fedora at the moment -- you'll need to keep that one.  Or preferrably, just package it too.

TODO: PERL_INSTALL_ROOT could be substituted with DESTDIR.

Comment 2 Mathieu Bridon 2013-11-25 05:05:39 UTC

Thanks for the feedback Petr.

I've opened a new review request for Test::Name::FromLine.

And here's a new package with the fixes. :)

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time-0.04-2.fc20.src.rpm

Comment 3 Mathieu Bridon 2013-11-26 09:23:46 UTC

A new package, removing the inc/ file from the MANIFEST (you asked for it in #1034017, I assumed you'd also ask for it here)

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time-0.04-3.fc20.src.rpm

Comment 4 Petr Šabata 2014-09-05 10:38:12 UTC

Acking changes, however, the module used in Makefile.PL is actually `inc::Module::Install', not `Module::Install'.  BuildRequire that.  We have the magic module in Fedora.  The other `Module::Install' deps are fine.

There are some more buildtime deps missing, namely strict, Test::More and warning.  All three of them are used by both tests and the module itself.

No other issues here.

Comment 5 Petr Šabata 2015-05-14 08:49:13 UTC

It's been over eight months now.  Ping?

Comment 6 Mathieu Bridon 2015-05-15 09:04:45 UTC

I'm not interested any more, no.

Sorry for not letting you know earlier, I hope I didn't cause any work for you. :(