Bug 1033551

Summary:	SyntaxError is seen when run ose-upgrade without any option on broker.
Product:	OpenShift Container Platform	Reporter:	Johnny Liu <jialiu>
Component:	Cluster Version Operator	Assignee:	Jason DeTiberus <jdetiber>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.0.0	CC:	bleanhar, jdetiber, libra-onpremise-devel
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-04 14:41:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Johnny Liu 2013-11-22 11:16:56 UTC

Description of problem:
SyntaxError is seen when run ose-upgrade without any option on broker.

Version-Release number of selected component (if applicable):
openshift-enterprise-release-2.0.0-2.git.4.f54bb4f.el6op.noarch
openshift-enterprise-upgrade-broker-2.0.0-2.git.4.f54bb4f.el6op.noarch

How reproducible:
Always

Steps to Reproduce:
1. Setup ose-1.2 env
2. Install openshift upgrade package
# yum install http://download.devel.redhat.com/brewroot/work/tasks/7537/6627537/openshift-enterprise-release-2.0.0-2.git.4.f54bb4f.el6op.noarch.rpm http://download.devel.redhat.com/brewroot/work/tasks/7537/6627537/openshift-enterprise-upgrade-broker-2.0.0-2.git.4.f54bb4f.el6op.noarch.rpm 
3. Run ose-upgrade without any option

Actual results:
# ose-upgrade 
INFO: Upgrade number 2 to version 2.0 is available to run.
INFO: OpenShift broker installed.
/opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/finder.rb:15:in `load': /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/broker/upgrades/2/upgrader.rb:17: syntax error, unexpected tQWORDS_BEG, expecting ':' (SyntaxError)
          %w[ pre outage rpms conf maintena...
              ^
	from /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/finder.rb:15:in `find_upgrader'
	from /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/main.rb:234:in `try_upgrader'
	from /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/main.rb:249:in `load_upgrader'
	from /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/main.rb:57:in `initialize'
	from /usr/bin/ose-upgrade:63:in `new'
	from /usr/bin/ose-upgrade:63:in `<main>'


Expected results:
No error is seen, and prompt user the upgrade order.

Additional info:
This issue does NOT occurs on node.
# ose-upgrade 
INFO: Upgrade number 2 to version 2.0 is available to run.
INFO: OpenShift node installed.
Current upgrade is number 2 to version 2.0.
Step sequence:
  begin pre outage rpms conf maintenance_mode end_maintenance_mode
Next step is: begin

Comment 2 Jason DeTiberus 2013-11-22 22:05:12 UTC

This has been fixed in the latest build (2.0.0a-1.git.3.908bd88.el6op)

Comment 3 Johnny Liu 2013-11-26 10:59:33 UTC

Verified this bug with openshift-enterprise-release-2.0.0a-1.git.7.8f100ae.el6op.noarch and openshift-enterprise-upgrade-broker-2.0.0a-1.git.7.8f100ae.el6op.noarch and PASS.

# ose-upgrade 
INFO: OpenShift broker installed.
Upgrade number 2 to version 2.0 is complete.