Bug 1033558

Summary:	02-node-backup-conf-files throw error during update node from ose-1.2 to ose-2.0
Product:	OpenShift Container Platform	Reporter:	Johnny Liu <jialiu>
Component:	Cluster Version Operator	Assignee:	Jason DeTiberus <jdetiber>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	2.0.0	CC:	bleanhar, jdetiber, libra-onpremise-devel
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-04 14:41:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Johnny Liu 2013-11-22 11:37:56 UTC

Description of problem:
ose-upgrade script is copying a non-existing file - /etc/mcollective/client.cfg, this file only exists on broker. That lead upgrade failure.

Version-Release number of selected component (if applicable):
openshift-enterprise-release-2.0.0-2.git.4.f54bb4f.el6op.noarch
openshift-enterprise-upgrade-node-2.0.0-2.git.4.f54bb4f.el6op.noarch

How reproducible:
Always

Steps to Reproduce:
1. Setup ose-1.2 env
2. Install openshift upgrade package
# yum install http://download.devel.redhat.com/brewroot/work/tasks/7537/6627537/openshift-enterprise-release-2.0.0-2.git.4.f54bb4f.el6op.noarch.rpm http://download.devel.redhat.com/brewroot/work/tasks/7537/6627537/openshift-enterprise-upgrade-node-2.0.0-2.git.4.f54bb4f.el6op.noarch.rpm 
3. Run "ose-upgrade all" on node.

Actual results:
The script is copying a non-existing file - /etc/mcollective/client.cfg, this file only exists on broker.
<--snip-->
INFO: running /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/node/upgrades/2/pre/02-node-backup-conf-files
ERROR: run_script
/opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/node/upgrades/2/pre/02-node-backup-conf-files had errors:
--BEGIN OUTPUT--
+ mkdir -p /etc/openshift/upgrade/2/
+ for file in /etc/mcollective/client.cfg /etc/mcollective/server.cfg /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /var/lib/openshift/.httpd.d/nodes.db /var/lib/openshift/.httpd.d/nodes.txt /var/lib/openshift/.httpd.d/geardb.json /var/lib/openshift/.httpd.d/routes.json
+ command cp -f /etc/mcollective/client.cfg /etc/openshift/upgrade/2/
+ cp -f /etc/mcollective/client.cfg /etc/openshift/upgrade/2/
cp: cannot stat `/etc/mcollective/client.cfg': No such file or directory

--END /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/node/upgrades/2/pre/02-node-backup-conf-files OUTPUT--
INFO: Setting node step 'pre' status to FAILED
<--snip-->


Expected results:
No error

Additional info:

Comment 2 Jason DeTiberus 2013-11-22 22:05:47 UTC

This has been fixed in the latest build (2.0.0a-1.git.3.908bd88.el6op)

Comment 3 Johnny Liu 2013-11-26 11:04:23 UTC

Verified this bug with openshift-enterprise-release-2.0.0a-1.git.7.8f100ae.el6op.noarch and openshift-enterprise-upgrade-node-2.0.0a-1.git.7.8f100ae.el6op.noarch and PASS.

INFO: running /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/node/upgrades/2/pre/02-node-backup-conf-files
INFO: /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/node/upgrades/2/pre/02-node-backup-conf-files ran without error:
--BEGIN OUTPUT--
+ mkdir -p /etc/openshift/upgrade/2/
+ for file in /etc/mcollective/server.cfg /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /var/lib/openshift/.httpd.d/nodes.db /var/lib/openshift/.httpd.d/nodes.txt /var/lib/openshift/.httpd.d/geardb.json /var/lib/openshift/.httpd.d/routes.json
+ command cp -f /etc/mcollective/server.cfg /etc/openshift/upgrade/2/
+ cp -f /etc/mcollective/server.cfg /etc/openshift/upgrade/2/
+ for file in /etc/mcollective/server.cfg /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /var/lib/openshift/.httpd.d/nodes.db /var/lib/openshift/.httpd.d/nodes.txt /var/lib/openshift/.httpd.d/geardb.json /var/lib/openshift/.httpd.d/routes.json
+ command cp -f /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /etc/openshift/upgrade/2/
+ cp -f /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /etc/openshift/upgrade/2/
+ for file in /etc/mcollective/server.cfg /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /var/lib/openshift/.httpd.d/nodes.db /var/lib/openshift/.httpd.d/nodes.txt /var/lib/openshift/.httpd.d/geardb.json /var/lib/openshift/.httpd.d/routes.json
+ command cp -f /var/lib/openshift/.httpd.d/nodes.db /etc/openshift/upgrade/2/
+ cp -f /var/lib/openshift/.httpd.d/nodes.db /etc/openshift/upgrade/2/
+ for file in /etc/mcollective/server.cfg /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /var/lib/openshift/.httpd.d/nodes.db /var/lib/openshift/.httpd.d/nodes.txt /var/lib/openshift/.httpd.d/geardb.json /var/lib/openshift/.httpd.d/routes.json
+ command cp -f /var/lib/openshift/.httpd.d/nodes.txt /etc/openshift/upgrade/2/
+ cp -f /var/lib/openshift/.httpd.d/nodes.txt /etc/openshift/upgrade/2/
+ for file in /etc/mcollective/server.cfg /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /var/lib/openshift/.httpd.d/nodes.db /var/lib/openshift/.httpd.d/nodes.txt /var/lib/openshift/.httpd.d/geardb.json /var/lib/openshift/.httpd.d/routes.json
+ command cp -f /var/lib/openshift/.httpd.d/geardb.json /etc/openshift/upgrade/2/
+ cp -f /var/lib/openshift/.httpd.d/geardb.json /etc/openshift/upgrade/2/
+ for file in /etc/mcollective/server.cfg /etc/httpd/conf.d/000001_openshift_origin_node_servername.conf /var/lib/openshift/.httpd.d/nodes.db /var/lib/openshift/.httpd.d/nodes.txt /var/lib/openshift/.httpd.d/geardb.json /var/lib/openshift/.httpd.d/routes.json
+ command cp -f /var/lib/openshift/.httpd.d/routes.json /etc/openshift/upgrade/2/
+ cp -f /var/lib/openshift/.httpd.d/routes.json /etc/openshift/upgrade/2/

--END /opt/rh/ruby193/root/usr/local/share/ruby/site_ruby/ose-upgrade/node/upgrades/2/pre/02-node-backup-conf-files OUTPUT--