Bug 1033572

Summary:	Git ref is not defaulted appropriately if not passed from the broker during a REST deployment
Product:	OpenShift Online	Reporter:	Jianwei Hou <jhou>
Component:	Image	Assignee:	Andy Goldstein <agoldste>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	agoldste, bmeng, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1033767 1034124 (view as bug list)		Environment:
Last Closed:	2014-01-30 00:50:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1033767, 1034124

Description Jianwei Hou 2013-11-22 12:07:27 UTC

Description of problem:
Create an application with auto_deploy disabled. Hot deploy this app via RESTAPI, the returned message show that hot_deploy is false. 
So is the case with force_clean_build.

Push commits to the app and then invoke RESTAPI to hot deploy the app. The returned content of RESTAPI shows that hot_deploy is false. Moreover, the app's web page returns 404.

Version-Release number of selected component (if applicable):
On STG(devenv-stage_582)

How reproducible:
Always

Steps to Reproduce:
1. Create an applicaton
rhc create-app php1 php-5.3
2. Make some change to app, commit and push
3. Hot deploy this app with RESTAPI
curl -s -k -H 'Content-Type: Application/json' --user jhou:x https://stg.openshift.redhat.com/broker/rest/domains/jhou/applications/p1/deployments -X POST -d '{"hot_deploy":true}'

Actual results:
After step 3: Although the hot_deploy is set as true, the returned message indicate hot_deploy is false.
<------------------------>
curl -s -k -H 'Content-Type: Application/json' --user jhou:x https://stg.openshift.redhat.com/broker/rest/domains/jhou/applications/p1/deployments -X POST -d '{"hot_deploy":true}'

{
    "api_version": 1.6,
    "data": {
        "activations": [
            "2013-11-22T12:04:41Z"
        ],
        "created_at": "2013-11-22T12:04:20Z",
        "force_clean_build": false,
        "hot_deploy": false,
        "id": "c57c21f7",
        "ref": "master",
        "sha1": "508b7b7"
    },
    "messages": [
        {
            "exit_code": 0,
            "field": null,
            "index": null,
            "severity": "info",
            "text": "Added c57c21f7 to application p1"
        }
    ],
    "status": "created",
    "supported_api_versions": [
        1.0,
        1.1,
        1.2,
        1.3,
        1.4,
        1.5,
        1.6
    ],
    "type": "deployment",
    "version": "1.6"
}

<------------------------>
Expected results:
The returned message should show that hot_deploy is true.
So is the case with force_clean_build, RESTAPI shows that force_clean_build is false then deploying this app with this feature enabled.

Additional info:

Comment 1 Andy Goldstein 2013-11-22 15:06:22 UTC

This is actually an issue where the node isn't defaulting the git ref if it's not passed in from the broker.

Comment 2 Andy Goldstein 2013-11-22 16:02:10 UTC

https://github.com/openshift/origin-server/pull/4226

Comment 3 openshift-github-bot 2013-11-22 17:59:12 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/f906a06c6de191787e7a03c32a41b78f937498a4
Bug 1033572

Use git ref default logic for both 'git push' and RESTful deployments

Comment 4 Jianwei Hou 2013-11-25 05:12:00 UTC

Verified on devenv_4067, hot deploy is enabled on RESTAPI calls, the app is deployed and the main process id didn't change.

 curl -s -k -H 'Content-Type: Application/json' --user jhou:redhat https://ec2-23-22-167-139.compute-1.amazonaws.com/broker/rest/domains/jhou/applications/php1/deployments -X POST -d '{"hot_deploy":true}'

+rest-hot-deploy-app:6> json_reformat
{
    "api_version": 1.6,
    "data": {
        "activations": [
            "2013-11-25T05:09:11Z"
        ],
        "created_at": "2013-11-25T05:09:05Z",
        "force_clean_build": false,
        "hot_deploy": true,
        "id": "05260138",
        "ref": "master",
        "sha1": "ab50758"
    },
    "messages": [
        {
            "exit_code": 0,
            "field": null,
            "index": null,
            "severity": "info",
            "text": "Added 05260138 to application php1"
        }
    ],
    "status": "created",
    "supported_api_versions": [
        1.0,
        1.1,
        1.2,
        1.3,
        1.4,
        1.5,
        1.6
    ],
    "type": "deployment",
    "version": "1.6"
}