| Summary: | loader.Loader.load_modules doesn't call Loader._needs_network correctly | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Adrian Likins <alikins> | ||||
| Component: | firstboot | Assignee: | Vratislav Podzimek <vpodzime> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Release Test Team <release-test-team> | ||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | urgent | ||||||
| Version: | 7.0 | CC: | andriusb, dcantrell, ddumas, dgregor, jstodola, mbanas, sbueno | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | firstboot-19.5-1 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-06-13 12:35:33 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 860099, 863175, 1025386 | ||||||
| Attachments: |
|
||||||
Created attachment 827881 [details]
fix missing Loader._needs_network call
Patch against master.
Reproduced with firstboot-19.4-2.el7 - Subscription Management Registration (SMR) started although no network interface was running. With firstboot-19.5-2.el7, SMR was started only when network interface was up and running. Moving to VERIFIED. This request was resolved in Red Hat Enterprise Linux 7.0. Contact your manager or support representative in case you have further questions about the request. |
Description of problem: diff --git i/firstboot/loader.py w/firstboot/loader.py index 2f65fbc..6373e32 100644 --- i/firstboot/loader.py +++ w/firstboot/loader.py @@ -84,7 +84,7 @@ class Loader: continue # skip modules that require network if it's not active - if not self._has_network and modobj.needsNetwork(): + if not self._has_network() and modobj.needsNetwork(): log.error('module requires active network connection') continue Loader doesn't call self._has_network, but just accidentally checks that it doesn't exists and ignores needsNetwork(). Module that do need network are not skipped if there is no networking.