Bug 1033701

Summary: oo-diagnostics DNS-checking test is too strict
Product: OpenShift Container Platform Reporter: Luke Meyer <lmeyer>
Component: NodeAssignee: Luke Meyer <lmeyer>
Status: CLOSED ERRATA QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.2.0CC: bleanhar, gpei, libra-onpremise-devel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-openshift-origin-common-1.17.2.2-1.el6op Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1033763 (view as bug list) Environment:
Last Closed: 2013-12-16 09:10:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1014882, 1033763    

Description Luke Meyer 2013-11-22 16:32:23 UTC
Description of problem:
The first test in oo-diagnostics checks that the first DNS server in /etc/resolv.conf is working properly. It checks for an NXDOMAIN response on a bogus domain. There are other valid responses that would not indicate a problem. For now it seems best to just validate that the server responds at all.

Steps to Reproduce:
1. Install an OSE system including BIND
2. Reconfigure BIND /etc/named.conf with "recursion no;" instead of "yes".
3. Run oo-diagnostics

Actual results:
Fails because server returns "REFUSED", not "NXDOMAIN".

Expected results:
Test should pass.

Additional info:
Other servers could also respond with other valid codes.
The best we can do in the general case is test that the server is at least responding, as the server being down or unreachable is the most common cause of problems. We could do better validating the actual app domain on brokers or nodes, but save that for a later update.

Comment 1 Luke Meyer 2013-11-22 16:51:15 UTC
origin-server:
commit e3e29eb1e9b40d275b0d4a6bd78544416f741c73
Author: Luke Meyer <lmeyer>
Date:   Fri Nov 22 11:34:08 2013 -0500

    <oo-diagnostics> loosen DNS test - bug 1033701

enterprise-1.2.z: commit c2b71ca01ebb6eb0839b83f8fceb6e73b679918b
enterprise-2.0: commit 90b1a61113635e4e8fa1db667ac039228b048092

Comment 5 Gaoyun Pei 2013-11-25 05:39:17 UTC
Verify this bug on rubygem-openshift-origin-common-1.17.2.2-1.el6op.noarch.
After configuring /etc/named.conf with "recursion no", run "oo-diagnostics" .
No error was thrown out.