Bug 1033779

Summary: Mouse move on a locked screen display Smart Card Manager smart card insert/removal event notifications.
Product: Red Hat Enterprise Linux 7 Reporter: Asha Akkiangady <aakkiang>
Component: escAssignee: Jack Magne <jmagne>
Status: CLOSED CURRENTRELEASE QA Contact: Asha Akkiangady <aakkiang>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 7.0CC: jgalipea, nkinder, rpattath, rstrode
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: esc-1.1.0-26.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 11:21:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Asha Akkiangady 2013-11-22 21:22:40 UTC
Description of problem:
Mouse move on a locked screen display Smart Card Manager smart card insert/removal event notifications.

Version-Release number of selected component (if applicable):
esc-1.1.0-25.el7.x86_64

How reproducible:


Steps to Reproduce:
1. System is configured to login with smart card and to lock the screen upon smart card removal.
2. Have an enrolled smart card.
3. Logged in successfully with a smart card.
4. Pull the smart card out of the reader.
5. Screen locks.

Actual results:
Move the mouse, below date and time display on the screen, there is a notification "Smart Card Manager" 1 new notification.

Expected results:
In previous RHEL releases notification was hidden by the screensaver, in RHEL 7 
notifications are shown at the locked screen.

We need a design decision whether ESC should bubble smart card insert/removal notifications or NOT. 

Additional info:
<aakkiang> on a locked screen, when mouse is moved, below date and time display, there is a notification "Smart Card Manager" 1 new notification .. is that expected?
<aakkiang> locked screen by pulling the smart card out of reader
<halfline> if you have ESC installed, then I guess that's expected
<aakkiang> yes, ESC is installed
<halfline> I don't think ESC should be popping up notifications when you insert and remove a smartcard, but that's a design decision
<halfline> aakkiang: jmagne: i was just saying i don't really think the notification bubbles are that good of an idea
<halfline> i mean the user knows if they just inserted a smartcard
<halfline> assuming the smartcard is already formatted and enrolled
<jmagne> halfline: Sure, I recall your stating that previously. I can see both sides.
<halfline> oh have we had this conversation before? :-)
<jmagne> halfline, originally that was what they told me to do :)
<jmagne> I remember you bringing it up during the SSO meetings we used to have.
<halfline> woah that's a blast from the past
<jmagne> halfine, I believe the rationale was that we are getting notified of something we know we are doing already.
<halfline> right
<halfline> it's extra ugly now because of the reason aakkiang pointed out
<jmagne> I believe rrelyea had an alternate opinion which I'm spacing on at the moment :)
<halfline> we now show when there are notifications at the lock screen
<jmagne> halfline, it would be no big deal whatsoever to fix that if it is decided we should do so.
<halfline> i think it would be a good idea
<halfline> but we are past beta
<halfline> so it would have to go in pretty quickly if it was to go in, i think
<aakkiang> halfline, that's becos the notification is put on the screen now
<halfline> right
<halfline> it was less of a wart when the notification was hidden by the screensaver
<jmagne> Perhaps we should loop nkinder_ into this.
<halfline> anyway, it was enough of an issue that aakkiang wondered if it was a bug
<halfline> it's clearly not a bug, just a design decision that should possibly be reconsidered
<jmagne> halfline, I"m open to what is best. Not my call though.
<halfline> aren't you the ESC maintainer?
<jmagne> It would prolly be easy to make them configurable and have them turned off by default.
<jmagne> halfline, yes I am.
<halfline> how is it not your call then ? :-)
<jmagne> Last time I checked I don't have managerial powers :)
<halfline> do you escalate all UI changes through management ?
<jmagne> Or PM powers.
<halfline> anyway, i guess the next step is to get a bug filed
<halfline> aakkiang: mind filing it?
<aakkiang> sure, will file
<jmagne> I was more speaking to the mechanics of pushing the bug through, but yes, we should file a bug.
<halfline> great, thanks
<halfline> ah okay
<halfline> jmagne: though, i'm curious if you're on board with the change?
<jmagne> halfline, I'm fine with it. I never had a strong opinion whether that feature was needed or not. Now that it is uglyfying the lock screen I'm fine with getting rid of it.
<halfline> ok, great
<halfline> as long as we're all on the same page
<halfline> i don't want to try to ram anything through you don't agree with or whatever
<jmagne> Sure, I wasn't looking for an argument or anything :)

Comment 2 Jack Magne 2013-11-27 18:48:41 UTC
Have local fix for this issue. Notifications will be off by default but configurable for any one that may want them.

Will submit this with the fix for another issue chasing.

Comment 3 Jack Magne 2013-11-27 23:14:59 UTC
Latest build addresses this:

Notifications are off by default.

If someone wants to turn them back on they can set the following pref
in defaults/preferences/esc-pres.js

change:

pref("esc.allow.notifications","no");  to

pref("esc.allow.notifications","yes");

Testing should test this scenario as well.

Comment 5 Jack Magne 2013-12-06 18:18:58 UTC
DOC:

This fix addresses an issue where ESC smart card notifications display out of context during certain Smart Card Login related screens. The notifications have been turned off by default, thus addressing this issue. The notifications can be manually requested by a new ESC configuration value (pref("esc.allow.notifications","yes").

Comment 6 Roshni 2014-02-06 20:23:58 UTC
pref("esc.allow.notifications","no") was initially set to "no" and there were no notifications on the date/time screen when the screen was locked. I changed modified the esc prefs to pref("esc.allow.notifications","yes"), the notifications started showing up on the lock screen. I again changed back to pref("esc.allow.notifications","no") but still the notifications on screen lock. I have to restart the machine for the changes to the esc prefs to be applied.

Comment 7 Jack Magne 2014-02-06 21:23:19 UTC
Probably something being cached in the user's esc profile, unless you did not restart the app.


Anyway, I think this is not a big deal, since most will simply leave the notificaitons off as per default.

Comment 8 Roshni 2014-02-07 18:45:29 UTC
I deleted the esc profiles and then locked the screen, the notifications are still being shown when pref("esc.allow.notifications","no")

Comment 9 Jack Magne 2014-02-07 19:00:06 UTC
Well, if the process was still running when you removed the profile, we might expect this to happen.

Comment 10 Roshni 2014-02-10 16:16:25 UTC
I restarted the ESC after deleting the profiles. The notifications still show up.

Comment 11 Ray Strode [halfline] 2014-02-10 16:56:17 UTC
you may have to manually dismiss pre-existing notifications or log out and log back in again after changing the setting.

Comment 12 Roshni 2014-02-11 15:31:00 UTC
The esc notifications works as expected when done as explained in comment 11

Comment 13 Roshni 2014-02-11 15:36:38 UTC
verified on esc-1.1.0-27.el7.x86_64

Comment 14 Ludek Smid 2014-06-13 11:21:58 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.