Bug 1033796

Summary: Review Request: golang-launchpad-gocheck - Rich testing framework for the Go language
Product: [Fedora] Fedora Reporter: Vincent Batts <vbatts>
Component: Package ReviewAssignee: Lokesh Mandvekar <lsm5>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: golang-updates, lemenkov, lsm5, package-review, walters
Target Milestone: ---Flags: lsm5: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: golang-launchpad-gocheck-0-0.2.bzr85.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-01 01:39:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vincent Batts 2013-11-22 23:19:10 UTC 
Spec URL: http://vbatts.fedorapeople.org/rpmbuild/SPECS/golang-launchpad-gocheck.spec
SRPM URL: http://vbatts.fedorapeople.org/rpmbuild/SRPMS/golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm
Description: Rich testing framework for the Go language
Fedora Account System Username: vbatts

 rpmlint golang-launchpad-gocheck.spec
golang-launchpad-gocheck.spec:34: W: setup-not-quiet
golang-launchpad-gocheck.spec: W: no-cleaning-of-buildroot %install
golang-launchpad-gocheck.spec: W: no-cleaning-of-buildroot %clean
golang-launchpad-gocheck.spec: W: no-buildroot-tag
golang-launchpad-gocheck.spec: W: no-%clean-section
0 packages and 1 specfiles checked; 0 errors, 5 warnings.

$ fedpkg scratch-build --srpm /home/vbatts/rpmbuild/SRPMS/golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm
Exception AttributeError: '_read_only' in <bound method write.__del__ of <git.config.write object at 0x1a13e50>> ignored
[====================================] 100% 00:00:00  30.31 KiB  52.27 KiB/sec
Building golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm for rawhide
Created task: 6215344
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6215344
Watching tasks (this may be safely interrupted)...
6215344 build (rawhide, golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm): free
6215344 build (rawhide, golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm): free -> open (buildvm-14.phx2.fedoraproject.org)
  6215345 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, armv7hl): free
  6215347 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, i686): free
  6215346 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, x86_64): free
  6215345 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, armv7hl): free -> open (arm02-builder22.arm.fedoraproject.org)
  6215346 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, x86_64): free -> open (buildvm-04.phx2.fedoraproject.org)
  6215347 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, i686): free -> open (buildvm-15.phx2.fedoraproject.org)
  6215346 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, x86_64): open (buildvm-04.phx2.fedoraproject.org) -> closed
  0 free  3 open  1 done  0 failed
  6215347 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, i686): open (buildvm-15.phx2.fedoraproject.org) -> closed
  0 free  2 open  2 done  0 failed
  6215345 buildArch (golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm, armv7hl): open (arm02-builder22.arm.fedoraproject.org) -> closed
  0 free  1 open  3 done  0 failed
6215344 build (rawhide, golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm): open (buildvm-14.phx2.fedoraproject.org) -> closed
  0 free  0 open  4 done  0 failed

6215344 build (rawhide, golang-launchpad-gocheck-0-0.1.bzr85.el6.src.rpm) completed successfully
Comment 1 Lokesh Mandvekar 2014-04-03 18:28:59 UTC 
BuildArch should go into main package  and BuildRequires in devel package (can remove this if no %check would be included). rest looks good :)
Comment 2 Lokesh Mandvekar 2014-04-11 16:10:05 UTC 
Spec URL: http://lsm5.fedorapeople.org/golang-launchpad-gocheck.spec
SRPM URL: http://lsm5.fedorapeople.org/golang-launchpad-gocheck-0-0.2.bzr85.fc21.src.rpm
Comment 3 Lokesh Mandvekar 2014-04-11 16:14:15 UTC 
Approved. This rpm aligns with the current golang packaging guidelines.
Comment 4 Vincent Batts 2014-04-11 16:53:37 UTC 
New Package SCM Request
=======================
Package Name: golang-launchpad-gocheck 
Short Description: Rich testing framework for the Go language
Owners: vbatts lsm5
Branches: f19 f20 el6 epel7
InitialCC: golang-sig
Comment 5 Gwyn Ciesla 2014-04-11 17:04:53 UTC 
Git done (by process-git-requests).
Comment 6 Fedora Update System 2014-04-11 20:33:13 UTC 
golang-launchpad-gocheck-0-0.2.bzr85.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-launchpad-gocheck-0-0.2.bzr85.fc20
Comment 7 Fedora Update System 2014-04-11 20:40:03 UTC 
golang-launchpad-gocheck-0-0.2.bzr85.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/golang-launchpad-gocheck-0-0.2.bzr85.fc19
Comment 8 Fedora Update System 2014-04-15 15:27:56 UTC 
golang-launchpad-gocheck-0-0.2.bzr85.fc19 has been pushed to the Fedora 19 testing repository.
Comment 10 Fedora Update System 2014-11-01 01:39:16 UTC 
golang-launchpad-gocheck-0-0.2.bzr85.fc19 has been pushed to the Fedora 19 stable repository.
Comment 11 Fedora Update System 2014-11-01 01:42:14 UTC 
golang-launchpad-gocheck-0-0.2.bzr85.fc20 has been pushed to the Fedora 20 stable repository.