| Summary: | Review Request: golang-labix-mgo - The mgo rich MongoDB driver for Go | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vincent Batts <vbatts> | ||||
| Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fpokorny, golang-updates, jchaloup, lemenkov, package-review | ||||
| Target Milestone: | --- | Flags: | lsm5:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-08-17 12:48:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Vincent Batts
2013-11-22 23:27:08 UTC
sorry, pasted the wrong scratch build info $ fedpkg scratch-build --srpm /home/vbatts/rpmbuild/SRPMS/golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm Exception AttributeError: '_read_only' in <bound method write.__del__ of <git.config.write object at 0x2fede50>> ignored [====================================] 100% 00:00:00 117.46 KiB 152.84 KiB/sec Building golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm for rawhide Created task: 6215585 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6215585 Watching tasks (this may be safely interrupted)... 6215585 build (rawhide, golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm): open (buildvm-15.phx2.fedoraproject.org) 6215586 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, armv7hl): free 6215587 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, x86_64): free 6215588 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, i686): free 6215586 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, armv7hl): free -> open (arm02-builder05.arm.fedoraproject.org) 6215587 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, x86_64): free -> open (buildvm-18.phx2.fedoraproject.org) 6215588 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, i686): free -> open (buildvm-23.phx2.fedoraproject.org) 6215587 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, x86_64): open (buildvm-18.phx2.fedoraproject.org) -> closed 0 free 3 open 1 done 0 failed 6215588 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, i686): open (buildvm-23.phx2.fedoraproject.org) -> closed 0 free 2 open 2 done 0 failed 6215586 buildArch (golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm, armv7hl): open (arm02-builder05.arm.fedoraproject.org) -> closed 0 free 1 open 3 done 0 failed 6215585 build (rawhide, golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm): open (buildvm-15.phx2.fedoraproject.org) -> closed 0 free 0 open 4 done 0 failed 6215585 build (rawhide, golang-labix-mgo-2013.11.18-0.1.bzr252.el6.src.rpm) completed successfully In this case since we have an upstream version number, the %{release} tag should be 1%{dist}.
Also, since upstream doesn't maintain tarballs, it's perhaps preferable to include in comments the steps to generate the tarball.
The version number here is probably more like a snapshot release timestamp.
In that case the timestamp is probably better off in %{release} as per this:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
Comments?
Perhaps others wanna chime in on this. Here's how upstream names it: http://labix.org/mgo
Since their "releases" is just a snapshot, and they do not even provide a tarball, I would like to keep the revno in the release. I've attached a script to pack the source. I'll include this script in the package's git repo. Here is the spec, with cleaned source/revno (252 was the wrong revno for that tag). SPEC: http://vbatts.fedorapeople.org/rpmbuild/SPECS/golang-labix-mgo.spec SRPM: http://vbatts.fedorapeople.org/rpmbuild/SRPMS/golang-labix-mgo-2013.11.18-0.2.bzr251.el6.src.rpm Created attachment 846190 [details]
script to pack the tagged snapshot of the source
the rev number needs an edit in the tarball filename too :) that being a minor issue, i'll do a final run and approve this in a bit Also, running 'sh pack_sources.sh' generates mgo-go1-253.tar.gz (using latest rev number). Perhaps we want to enter rev number in the script itself (if I'm reading it right, the script currently gets the latest rev number) sorry, i set the default tag to "go1", which is always the latest in their project. For any given tag, like r2013.11.18, run it like TAG=r2013.11.18 sh pack_sources.sh added comment for source packing SPEC: http://vbatts.fedorapeople.org/rpmbuild/SPECS/golang-labix-mgo.spec SRPM: http://vbatts.fedorapeople.org/rpmbuild/SRPMS/golang-labix-mgo-2013.11.18-0.3.bzr251.el6.src.rpm Approved. Only golang sources and docs packaged currently, this may change as golang packaging guidelines evolve. Jan, Fridolin, could you please take care of this package too? :) Packaged in golang-github-go-mgo-mgo. It can be closed. |