Bug 1033800

Taking it.

Looks good, APPROVED. One minor detail: removal of Gemfile/Rakefile could go in %prep but that's not a stopper, do as you wish.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[-]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
     Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Test run failed
[-]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.

Ruby:
[ ]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Package contains Requires: ruby(release).

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[x]: Gem should use %gem_install macro.
[x]: Specfile should use macros from rubygem-devel package.
[x]: Gem package should exclude cached Gem.
[x]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Test run failed
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-pkgwat-0.1.4-4.fc21.noarch.rpm
          rubygem-pkgwat-doc-0.1.4-4.fc21.noarch.rpm
          rubygem-pkgwat-0.1.4-4.fc21.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint rubygem-pkgwat rubygem-pkgwat-doc
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'



Requires
--------
rubygem-pkgwat (rpmlib, GLIBC filtered):
    ruby(release)
    ruby(rubygems)
    rubygem(json)
    rubygem(nokogiri)
    rubygem(rake)
    rubygem(sanitize)

rubygem-pkgwat-doc (rpmlib, GLIBC filtered):
    rubygem-pkgwat



Provides
--------
rubygem-pkgwat:
    rubygem(pkgwat)
    rubygem-pkgwat

rubygem-pkgwat-doc:
    rubygem-pkgwat-doc



Source checksums
----------------
https://rubygems.org/gems/pkgwat-0.1.4.gem :
  CHECKSUM(SHA256) this package     : 91bb190fb69e86a42db6321b16a53f4d0adfa07637f788214a4d1dfec81e2e3e
  CHECKSUM(SHA256) upstream package : 91bb190fb69e86a42db6321b16a53f4d0adfa07637f788214a4d1dfec81e2e3e


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1033800
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, PHP
Disabled flags: EPEL5, EXARCH, DISTTAG

Thanks very much Achilleas for the review! By the way, feel free to request co-maintainership if you want.


(In reply to Achilleas Pipinellis from comment #2)
> Looks good, APPROVED. One minor detail: removal of Gemfile/Rakefile could go
> in %prep but that's not a stopper, do as you wish.

Well, it's happening in %prep already :) See https://github.com/axilleas/fedora/commit/fff1092a5a6261b751a565fb3c8089e7ebe86ff2


New Package SCM Request
=======================
Package Name: rubygem-pkgwat
Short Description: Check your gems against Fedora/EPEL
Owners: ktdreyer
Branches: f19 f20

(In reply to Ken Dreyer from comment #3)
> (In reply to Achilleas Pipinellis from comment #2)
> > Looks good, APPROVED. One minor detail: removal of Gemfile/Rakefile could go
> > in %prep but that's not a stopper, do as you wish.
> 
> Well, it's happening in %prep already :) See
> https://github.com/axilleas/fedora/commit/
> fff1092a5a6261b751a565fb3c8089e7ebe86ff2
> 

Oops, you're right!

Git done (by process-git-requests).

rubygem-pkgwat-0.1.4-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/rubygem-pkgwat-0.1.4-4.fc20

rubygem-pkgwat-0.1.4-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rubygem-pkgwat-0.1.4-4.fc19

rubygem-pkgwat-0.1.4-4.fc20 has been pushed to the Fedora 20 testing repository.

rubygem-pkgwat-0.1.4-4.fc19 has been pushed to the Fedora 19 stable repository.

rubygem-pkgwat-0.1.4-4.fc20 has been pushed to the Fedora 20 stable repository.