| Summary: | Review Request: perl-Lingua-EN-Fathom - Measure readability of English text | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ruediger Landmann <rlandman> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jfearn, package-review, panemade, ppisar |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-24 05:54:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1033986 | ||
| Bug Blocks: | |||
|
Description
Ruediger Landmann
2013-11-25 00:58:39 UTC
The whiteboard says this package is not ready but I have tested this package in mock.
+ package builds in rawhide mock
+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ source verified with upstream as (sha1256sum)
srpm tarball ff90d74714d3fc04b928b1d467cfbe206d89cfce4a466b065311d98e03849897
upstream tarball ff90d74714d3fc04b928b1d467cfbe206d89cfce4a466b065311d98e03849897
+ make check gave
All tests successful.
Files=3, Tests=15, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU)
+ Package perl-Lingua-EN-Fathom-1.15-1.fc21.noarch
Provides: perl(Lingua::EN::Fathom) = 1.15 perl-Lingua-EN-Fathom = 1.15-1.fc21
Requires: perl(Lingua::EN::Syllable) perl(strict) perl(warnings)
I suppose this package also need to be built in EPEL so spec looks ok.
suggestions
1) yum/rpm picks required perl dependencies automatically so this package don't need following in spec
Requires: perl(Lingua::EN::Syllable)
2) you may want to remove line also
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
Hi, Rudi is a bit busy so I've made the requested changes. http://fedorapeople.org/~jfearn/files/perl-Lingua-EN-Fathom-1.15-2.fc19.src.rpm http://fedorapeople.org/~jfearn/files/perl-Lingua-EN-Fathom.spec The new srpm package looks good. APPROVED. New Package SCM Request ======================= Package Name: perl-Lingua-EN-Fathom Short Description: Measure readability of English text Owners: rlandmann jfearn Branches: f18 f19 f20 el5 el6 InitialCC: perl-sig Git done (by process-git-requests). No new f18 branches are being created. Thanks Parag, Jeff, and Jon :) This package has not been committed and built for F21:
petr@dhcp-0-146:~/fedora/perl-Lingua-EN-Fathom $ git branch
* master
petr@dhcp-0-146:~/fedora/perl-Lingua-EN-Fathom $ git log
commit bd88cd7fe8256d6107b3e860839d86b90c0a8502
Author: Fedora Release Engineering <rel-eng.org>
Date: Thu Jan 9 14:09:47 2014 +0000
Initial setup of the repo
You have to build from master branch for the Rawhide Fedora.
|