Bug 1034015

Summary: xfstests xfs/302: xfsrestore segfaults
Product: Red Hat Enterprise Linux 7 Reporter: Eryu Guan <eguan>
Component: xfsdumpAssignee: Eric Sandeen <esandeen>
Status: CLOSED CURRENTRELEASE QA Contact: Eryu Guan <eguan>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0CC: branto
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: xfsdump-3.1.3-2.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 11:23:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Full test log none

Description Eryu Guan 2013-11-25 04:48:57 UTC
Created attachment 828513 [details]
Full test log

Description of problem:
=== full diff out/out.bad ===
--- /dev/fd/63	2013-11-15 09:09:51.054274564 -0500
+++ results/xfs/302.out.bad	2013-11-15 09:09:48.920390607 -0500
@@ -1,2 +1,5 @@
 QA output created by 302
 Silence is golden.
+./tests/xfs/302: line 66:  1454 Segmentation fault      $XFSRESTORE_PROG -F -f $tmp.stream1 -f $tmp.stream2 $restore_dir >> $seqres.full 2>&1
+restore failed
+(see /var/lib/xfstests/results//xfs/302.full for details)

And dmesg says
[10415.908023] xfsrestore[1456]: segfault at 20 ip 0000000000425ccd sp 00007feda23894e0 error 4 in xfsrestore[400000+53000]

Version-Release number of selected component (if applicable):
xfsdump-3.1.3-1.el7

How reproducible:
always

Steps to Reproduce:
1. check xfs/302 on xfs
2.
3.

Actual results:
test fails

Expected results:
test passes

Additional info:

Comment 1 Eric Sandeen 2013-11-25 16:15:50 UTC
Should be fixed by:

commit 1162bdbcff77ed2341f0a9294db76df80f2f36a3
Author: Eric Sandeen <sandeen>
Date:   Tue Oct 8 22:05:54 2013 +0000

    xfsdump: avoid segfault in partial_reg() in error case

I'll get that & related patches into the build, thanks.

-Eric

Comment 2 Eric Sandeen 2013-11-25 19:10:55 UTC
Fixed & built in xfsdump-3.1.3-2.el7

Comment 4 Eryu Guan 2014-01-02 07:32:10 UTC
Verified with xfsdump-3.1.3-2.el7, xfs/302 passed with no segfault

Set to VERIFIED.

Comment 6 Ludek Smid 2014-06-13 11:23:41 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.