Bug 1034017

Summary: Review Request: perl-Test-Name-FromLine - Auto fill test names from caller line
Product: [Fedora] Fedora Reporter: Mathieu Bridon <bochecha>
Component: Package ReviewAssignee: Petr Šabata <psabata>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, psabata
Target Milestone: ---Flags: psabata: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-27 09:57:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1033481    

Description Mathieu Bridon 2013-11-25 04:50:32 UTC
Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Name-FromLine.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Test-Name-FromLine-0.11-1.fc20.src.rpm

Description:
Test::Name::FromLine is test utility that fills test names from its file.
Just use this module in test and this module fill test names to all test
except named one.

Fedora Account System Username: bochecha

Comment 1 Petr Šabata 2013-11-25 11:22:11 UTC
TIP: Also delete the inc files from MANIFEST.

TODO: Please, come up with a better description and summary (or fix the grammar mistakes at least).  It's quite unclear what the module actually does.

FIX/TODO: Missing buildtime deps:
perl(CPAN::Meta), ./Build.PL:15
perl(CPAN::Meta::Prereqs), ./Build.PL:16
perl(Cwd), ./lib/Test/Name/FromLine.pm:11, ./t/chdir.t:7
perl(File::Basename), ./Build.PL:13
perl(File::Spec), ./Build.PL:14, ./lib/Test/Name/FromLine.pm:10
perl(File::Temp), ./t/chdir.t:6
perl(lib), ./t/02_invalid_level.t:3, ./t/03_pass.t:3
perl(strict), ./Build.PL:8, ./lib/Test/Name/FromLine.pm:3, +tests...
perl(utf8), ./Build.PL:10
perl(warnings), ./Build.PL:9, ./lib/Test/Name/FromLine.pm:4,16, +tests...

TODO: Drop the explicit File::Slurp and Test::Builder runtime dependencies.  rpmbuild should pick those up automatically.

TODO: Drop the useless EE::MM dependency.

Comment 2 Mathieu Bridon 2013-11-26 08:35:53 UTC
Thanks for the feedback Petr.

All points should be fixed in this new package.

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Name-FromLine.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Test-Name-FromLine-0.11-2.fc20.src.rpm

----------

On the summary/description, I agree that the original one was pretty terrible. The new one should be a bit better, but it's not very clear either.

The idea is that you should name your tests when using Test::More:
  http://search.cpan.org/~rjbs/Test-Simple-1.001002/lib/Test/More.pm#Test_names

With this package, tests are automatically named, based on the line of code that defines them.

For example, the following test file:

  use Test::More;

  is(1, 1);
  done_testing();

Would output:

  ok 1

This is because the test is not named. Using Test::Name::FromLine, the output would become:

  ok 1 - L3: is 1, 1;

That is, as if the test had been defined as follows:

  use Test::More;

  is(1, 1, "L3: is 1, 1;");
  done_testing();

Now, I hope the new summary and description make that a bit more clear, but if you still find it lacking (and/or if you have ideas to improve it), I'll try harder. :)

Comment 3 Petr Šabata 2013-11-26 08:41:42 UTC
Thanks for the explanation :)
It's much better now.

Approving.

Comment 4 Mathieu Bridon 2013-11-26 08:44:34 UTC
Thanks for one more review, Petr!

----------

New Package SCM Request
=======================
Package Name: perl-Test-Name-FromLine
Short Description: Automatically name tests from their source code
Owners: bochecha
Branches: devel
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-11-26 13:30:56 UTC
Git done (by process-git-requests).

Comment 6 Mathieu Bridon 2013-11-27 09:57:02 UTC
Thanks for the Git process, Jon!

Package built in Rawhide, closing.