Bug 1034060
Summary: | append /usr/bin/zsh to /etc/shells | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | kealthou |
Component: | zsh | Assignee: | Dominic Hopf <dmaphy> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 19 | CC: | dmaphy, i, james.antill, mark |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | zsh-5.0.5-1.fc19 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-07-13 02:53:10 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
kealthou
2013-11-25 08:03:07 UTC
zsh-5.0.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/zsh-5.0.5-1.fc20 zsh-5.0.5-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/zsh-5.0.5-1.fc19 Thanks very much for reporting this issue and your patience while I investigated some issues with building 5.0.5. The issue here rather was, that %{_bindir} was set to /bin in the package and thus the whole Zsh binary was installed to /bin before. This behavior has now been changed and we're using the default value for %{_bindir} which points to /usr/bin. Since /bin is just a symbolic link to /usr/bin this should work without any issues and the correct path will be appended to /etc/shells now. Please feel free to test this and provide me with feedback as soon as the update is available via updates-testing. (In reply to Dominic Hopf from comment #3) > Thanks very much for reporting this issue and your patience while I > investigated some issues with building 5.0.5. The issue here rather was, > that %{_bindir} was set to /bin in the package and thus the whole Zsh binary > was installed to /bin before. > > This behavior has now been changed and we're using the default value for > %{_bindir} which points to /usr/bin. Since /bin is just a symbolic link to > /usr/bin this should work without any issues and the correct path will be > appended to /etc/shells now. > > Please feel free to test this and provide me with feedback as soon as the > update is available via updates-testing. Please take a look at this(my draft, turned into guideline as well): https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shells That's probably right since the zsh could be invoked via /bin/zsh as well as /usr/bin/zsh. The link you posted does not cover the uninstallation process, though. Zsh does the following in %postun currently: %postun if [ "$1" = 0 ] ; then if [ -f %{_sysconfdir}/shells ] ; then TmpFile=`%{_bindir}/mktemp /tmp/.zshrpmXXXXXX` grep -v '^%{_bindir}/zsh$' %{_sysconfdir}/shells > $TmpFile cp -f $TmpFile %{_sysconfdir}/shells rm -f $TmpFile fi fi Are we able to just add something like that as well to the wiki page? (In reply to Dominic Hopf from comment #5) > That's probably right since the zsh could be invoked via /bin/zsh as well as > /usr/bin/zsh. The link you posted does not cover the uninstallation process, > though. Zsh does the following in %postun currently: Why didn't it cover the postun??? Seems I just overlooked something, sorry. I've applied this for Rawhide now. Package zsh-5.0.5-1.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing zsh-5.0.5-1.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-8041/zsh-5.0.5-1.fc19 then log in and leave karma (feedback). zsh-5.0.5-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. zsh-5.0.5-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |