Bug 1034110

Summary: It will return succeeded when deleting non-installed cartridge via oo-cartridge command
Product: OpenShift Online Reporter: Meng Bo <bmeng>
Component: ContainersAssignee: Dan McPherson <dmcphers>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 2.xCC: dmcphers, mfojtik
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-30 00:50:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Meng Bo 2013-11-25 09:36:00 UTC 
Description of problem:
Use oo-cartridge to delete cartridge for gears, it will return succeeded even if the specified cartridge was not installed to the gear.

Version-Release number of selected component (if applicable):
devenv_4067

How reproducible:
always

Steps to Reproduce:
1. Create app
2. Try to delete a non-installed cartridge via oo-cartridge
oo-cartridge --action delete --with-container-uuid 5292ed54e30cd02eec00000b --with-cartridge-name mysql-5.1
3.

Actual results:
It will return "Cartridge delete succeeded".

Expected results:
Should show message about the cartridge was not installed for the gear.

Additional info:
Comment 1 Meng Bo 2013-12-20 05:29:12 UTC 
Checked on latest devenv(devenv_4160), the issue still can be reproduced.
Comment 2 Michal Fojtik 2014-01-20 18:48:28 UTC 
Dan: https://github.com/openshift/origin-server/pull/4297
Comment 3 Dan McPherson 2014-01-20 20:58:55 UTC 
https://github.com/openshift/origin-server/pull/4530
Comment 4 openshift-github-bot 2014-01-20 23:09:46 UTC 
Commits pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/b103e52767785c42fb510e2a89309d8316755714
Bug 1034110

https://github.com/openshift/origin-server/commit/71d021d3397fa6b14f3737b61738d2b4990c5a87
Merge pull request #4530 from danmcp/bug1034110

Merged by openshift-bot
Comment 5 Dan McPherson 2014-01-21 06:02:17 UTC 
https://github.com/openshift/origin-server/pull/4538
Comment 6 openshift-github-bot 2014-01-21 07:24:28 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/843abc0fd22a8375fddc11b457d398463d3c16d0
Bug 1034110
Comment 7 Meng Bo 2014-01-21 10:53:57 UTC 
[root@ip-10-73-212-24 ~]# oo-cartridge --action delete --with-container-uuid 52de50e9c9add372ff000001 --with-cartridge-name mysql-5.1
Cartridge 'mysql-5.1' is not installed in gear with uuid: 52de50e9c9add372ff000001

Issue fixed on devenv_4251.