Bug 1034226

Summary:	Chapter 16. JDBC Based Cache Stores, Jdbc cache store names should be changed
Product:	[JBoss] JBoss Data Grid 6	Reporter:	Vitalii Chepeliuk <vchepeli>
Component:	Documentation	Assignee:	Misha H. Ali <mhusnain>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.2.0	CC:	jdg-bugs, vchepeli
Target Milestone:	GA
Target Release:	6.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:	Build Name: 12532, Administration and Configuration Guide-6.2-3 Build Date: 25-11-2013 20:36:18 Topic ID: 5257-541807 [Latest]
Last Closed:	2014-01-16 00:02:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Vitalii Chepeliuk 2013-11-25 13:03:45 UTC

Title: JDBC Based Cache Stores
There are no following cache stores in infinispan 6.0.0, they should be changed with suggestions and following usage in the text

Describe the issue: 
JdbcBinaryCacheStore.
JdbcStringBasedCacheStore.
JdbcMixedCacheStore. 

Suggestions for improvement:
JdbcBinaryCacheStore.
JdbcStringBasedCacheStore.
JdbcMixedCacheStore. 

Additional information:

Comment 2 Misha H. Ali 2013-11-26 01:14:02 UTC

Hi Vitalii, 

Maybe I'm missing what you meant, but the described issue and suggestion for improvement look the same to me. Could you please clarify what you wanted changed for this bug?

Comment 3 Vitalii Chepeliuk 2013-11-26 07:57:35 UTC

Yep Misha you are right suggestions should be
JdbcBinaryStore.
JdbcStringBasedStore.
JdbcMixedStore. 

That's because name changes

Comment 5 Misha H. Ali 2013-11-27 00:58:12 UTC

Flagging Vitalii to request review.

Comment 6 Vitalii Chepeliuk 2013-11-27 09:49:36 UTC

Procedure 16.3. JdbcBinaryStore Programmatic Configuration (Library Mode)
Here is little mistake on second line letter "b" is misses
ConfigurationBuilder builder = new ConfigurationBuilder();
  uilder.persistence()

Comment 7 Vitalii Chepeliuk 2013-11-27 10:12:22 UTC

and this item 
2. Add the JdbcBinaryStore Loader
should be changed to
2. Add the JdbcBinaryStore configuration builder to build specific configuration related to this store
And the same should be applied for JdbcStringBasedStores and JdbcMixedStores Programmatic Configurations
2. Add the JdbcStringBasedStore configuration builder to build specific configuration related to this store

2. Add the JdbcMixedStore configuration builder to build specific 
configuration related to this store

And
Procedure 16.9. Configure JdbcMixedStore in Library Mode
"org.infinispan.loaders.keymappers.DefaultTwoWayKey2StringMapper"
should be changed to 
"org.infinispan.persistence.keymappers.DefaultTwoWayKey2StringMapper"

Comment 8 Misha H. Ali 2013-11-27 10:27:38 UTC

(In reply to Vitalii Chepeliuk from comment #6)
> Procedure 16.3. JdbcBinaryStore Programmatic Configuration (Library Mode)
> Here is little mistake on second line letter "b" is misses
> ConfigurationBuilder builder = new ConfigurationBuilder();
>   uilder.persistence()

NP, this is now fixed.

(In reply to Vitalii Chepeliuk from comment #7)
> and this item 
> 2. Add the JdbcBinaryStore Loader
> should be changed to
> 2. Add the JdbcBinaryStore configuration builder to build specific
> configuration related to this store
> And the same should be applied for JdbcStringBasedStores and JdbcMixedStores
> Programmatic Configurations
> 2. Add the JdbcStringBasedStore configuration builder to build specific
> configuration related to this store
> 
> 2. Add the JdbcMixedStore configuration builder to build specific 
> configuration related to this store
> 

OK, done for:

* JdbcStringBasedStore Programmatic Configuration
* JdbcBinaryStore Programmatic Configuration
* JdbcMixedStore Programmatic Configuration

> And
> Procedure 16.9. Configure JdbcMixedStore in Library Mode
> "org.infinispan.loaders.keymappers.DefaultTwoWayKey2StringMapper"
> should be changed to 
> "org.infinispan.persistence.keymappers.DefaultTwoWayKey2StringMapper"

Changed all instances.

Setting this back for verification.

Comment 9 Vitalii Chepeliuk 2013-11-27 10:40:26 UTC

Ok nice Misha! And please change please then

2. Add the JdbcBinaryStore Loader 
to 
2. Add the JdbcBinaryStoreConfigurationBuilder


2. Add JdbcStringBasedStore Loader 
to 
2. Add JdbcStringBasedStoreConfigurationBuilder

2. JdbcMixedStore Loader
to 
2. JdbcMixedStoreConfigurationBuilder

Because there are already no "Loader: for configuring this programatically

Comment 10 Vitalii Chepeliuk 2013-11-27 10:45:05 UTC

Sorry 
2. Add JdbcMixedStore Loader
to 
2. Add JdbcMixedStoreConfigurationBuilder
In last one case

Comment 11 Misha H. Ali 2013-11-27 10:59:54 UTC

All three now done!

Comment 12 Misha H. Ali 2014-01-16 00:02:55 UTC

The fix for this bug is now generally released and available here:

https://access.redhat.com/site/documentation/en-US/Red_Hat_JBoss_Data_Grid/6.2/index.html