Bug 1034387

Summary:	Review Request: lasso - Library that implements the Liberty alliance Single Sign On specification
Product:	[Fedora] Fedora	Reporter:	Simo Sorce <ssorce>
Component:	Package Review	Assignee:	Nalin Dahyabhai <nalin>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	nalin, package-review
Target Milestone:	---	Flags:	nalin: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-05 19:08:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Simo Sorce 2013-11-25 18:05:37 UTC

Spec URL: http://simo.fedorapeople.org/lasso/0/lasso.spec
SRPM URL: http://simo.fedorapeople.org/lasso/0/lasso-2.3.6-0.20131125.0.fc20.src.rpm
Description: Library that implements the Liberty alliance Single Sign On specification
Fedora Account System Username: simo

Comment 1 Simo Sorce 2013-11-26 00:36:02 UTC

Michele pointed out some issue with version 0.
Here are new spec and srpms.

Spec URL: http://simo.fedorapeople.org/lasso/1/lasso.spec
SRPM URL: http://simo.fedorapeople.org/lasso/1/lasso-2.3.6-0.20131125.0.fc20.src.rpm

Comment 2 Simo Sorce 2013-11-26 00:37:26 UTC

(In reply to Simo Sorce from comment #1)
> Michele pointed out some issue with version 0.
> Here are new spec and srpms.
> 
> Spec URL: http://simo.fedorapeople.org/lasso/1/lasso.spec
> SRPM URL:
> http://simo.fedorapeople.org/lasso/1/lasso-2.3.6-0.20131125.0.fc20.src.rpm

Sorry copy&paste error, these are the right names:
Spec URL: http://simo.fedorapeople.org/lasso/1/lasso.spec
SRPM URL: http://simo.fedorapeople.org/lasso/1/lasso-2.3.6-0.20131125.1.fc20.src.rpm

Comment 3 Nalin Dahyabhai 2013-11-26 18:30:15 UTC

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- The BuildRequires: on jpackage-utils seems to be missing, and the java
  subpackage on BuildRequires: on python-lxml is a surprise, though so
  long as it's not a copy/paste error in the .spec file, it's fine.
- I see a few javadoc-style comments in the bindings, so the notes about
  javadoc generation and installation may be relevant:
  - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
    Note: No javadoc subpackage present
    See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
  - Javadoc documentation files are generated and included in -javadoc
    subpackage
    Note: No javadoc subpackage present
    See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Is the rst source for the much of the docs supposed to be the only
  thing that's installed, or is python-sphinx supposed to be used to
  generate another format for consumption?
- Package doesn't use $RPM_OPT_FLAGS.
- Nit: %post/%postun could use '-p /sbin/ldconfig' to avoid a shell dependency.
- License isn't installed with the shared library package.
- Shared library package is required by other subpackages, but not in an arch-
  specific way.
- The php subpackage should probably own %{_datadir}/php/%{name}.
- The debuginfo package seems to be missing necessary information.
- The shared library package appears to explicitly require packages for which
  it already has automatic dependencies.
- A %check section that runs 'make check' could be added, unless there's
  reason to not.



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
     - Could probably run configure wiht --enable-static to save some
       time, but it creates problems later in the build.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
     - With no other commands to execute in the scriptlets, specifying
       ldconfig as the script interpreter using "%post -p
       /sbin/ldconfig" and such would remove the shell as a dependency.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)",
     "Unknown or generated". 46 files have unknown license. Detailed output of
     licensecheck in /tmp/1034387-lasso/licensecheck.txt
     - rpmlint's really upset about the incorrect addresses; please make
       sure they're reported upstream.
[!]: License file installed when any subpackage combination is installed.
     - Please move the top-level COPYING and README files (the latter
       includes the note about an OpenSSL exception) to the main
       package.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/php/lasso, /usr/lib64/java
     - The php subpackage should probably own %{_datadir}/php/%{name}.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/php/lasso,
     /usr/lib64/java
     - The php subpackage should probably own %{_datadir}/php/%{name}.
[!]: %build honors applicable compiler flags or justifies otherwise.
     - Building with --disable-silent-rules suggests that this needs
       to be fixed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
     - Passing %{_prefix}/sasl2 to configure's --with-sasl2 flag doesn't
       appear to have the desired effect.  The purpose of setting
       exec_prefix to %{_prefix} rather than %{_exec_prefix}, or leaving
       it alone, is unclear.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
     - The main package's explicit Requires: on xmlsec1, openssl, and
       xmlsec1-openssl are also handled by shared library dependencies.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
     - The debuginfo package doesn't contain any source files.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

Maven:
[ ]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: Old add_to_maven_depmap macro is not being used

Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lasso-doc ,
     lasso-devel , lasso-java , lasso-php , lasso-python
     - Requires: on lasso don't include %{?_isa}.
[?]: Package functions as described.
[x]: Latest version is packaged.
     - Latest release + backported patches.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
     - Scratch build on i386, x86_64, armv7hl.
[!]: %check is present and all tests pass.
     - There aren't many self-tests that attempt to run on my system,
       but there are some.
[!]: Packages should try to preserve timestamps of original installed files.
     - The number of header files which get patched and therefore have
       new timestamps could be a problem for multilib.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %{!?python_sitearch: %define
     python_sitearch %(%{__python} -c 'from distutils import sysconfig; print
     sysconfig.get_python_lib(1)')}, %define with_java 1, %define with_php 1,
     %define with_perl 0, %define with_python 1, %define with_wsf 0
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.

Java:
[x]: Packages are noarch unless they use JNI
     Note: lasso subpackage is not noarch. Please verify manually
[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 1955840 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: lasso-2.3.6-0.20131125.1.fc20.x86_64.rpm
          lasso-doc-2.3.6-0.20131125.1.fc20.x86_64.rpm
          lasso-devel-2.3.6-0.20131125.1.fc20.x86_64.rpm
          lasso-java-2.3.6-0.20131125.1.fc20.x86_64.rpm
          lasso-php-2.3.6-0.20131125.1.fc20.x86_64.rpm
          lasso-python-2.3.6-0.20131125.1.fc20.x86_64.rpm
          lasso-2.3.6-0.20131125.1.fc20.src.rpm
lasso.x86_64: W: no-documentation
lasso-devel.x86_64: W: no-documentation
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_confirmation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_rsa_key_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_entries.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_advice.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authn_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/tools.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/name_id_management.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_idp_entry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_terminate.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_body.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_detail.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_key_info_confirmation_data_type.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_evidence.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_conditions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_logout_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_extensions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_key_info.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_audience_restriction.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/logout.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authz_decision_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/registry-private.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_condition_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_status_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_federation_termination_notification.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authz_decision_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_assertion_id_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/assertion_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_designator.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_code.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_attribute_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_response_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_idp_list.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/server.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_name_identifier_mapping_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/debug.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_entry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_confirmation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/lasso.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/utils.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_register_name_identifier_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_x509_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_fault.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/keyprivate.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/federation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_proxy_restriction.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_requested_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_action.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_confirmation_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_locality.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/login.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_key_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/name_identifier_mapping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/logging.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_mapping_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_mapping_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/xml_enc.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_name_identifier.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_manage_name_id_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_base_idabstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_request_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/ecp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/export.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/xml_soap11.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_key_info_confirmation_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_request_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_request_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/saml2_helper.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_artifact_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_policy.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_request_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authentication_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/key.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/profile.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/profile.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/ctypes.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_list.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/misc_text_node.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_encrypted_element.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_register_name_identifier_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_xsd.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_name_identifier_mapping_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_status_code.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/xml_dsig.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/identity.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_advice.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_logout_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_authentication_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authn_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_authority_binding.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_header.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_one_time_use.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_manage_name_id_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_locality.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_condition_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_audience_restriction_condition.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/lecp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/errors.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_logout_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_response_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_name_id.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/session.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_logout_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authn_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_status.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/provider.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/backward_comp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/provider.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_artifact_resolve.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/defederation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_conditions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/name_registration.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_subject_query_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/registry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/xml.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_scoping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_scoping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_detail.h
lasso-java.x86_64: W: no-documentation
lasso-php.x86_64: W: no-documentation
lasso-php.x86_64: E: script-without-shebang /usr/share/php/lasso/lasso.php
lasso-python.x86_64: W: no-documentation
7 packages and 0 specfiles checked; 147 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint lasso-java lasso-python lasso-php lasso-doc lasso-deve 
l lasso
lasso-java.x86_64: W: no-documentation
lasso-python.x86_64: W: no-documentation
lasso-php.x86_64: W: no-documentation
lasso-php.x86_64: E: script-without-shebang /usr/share/php/lasso/lasso.php
lasso-devel.x86_64: W: no-documentation
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_confirmation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_rsa_key_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_entries.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_advice.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authn_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/tools.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/name_id_management.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_idp_entry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_terminate.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_body.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_detail.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_key_info_confirmation_data_type.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_evidence.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_conditions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_logout_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_extensions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_key_info.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_audience_restriction.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/logout.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authz_decision_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/registry-private.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_condition_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_status_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_federation_termination_notification.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authz_decision_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_assertion_id_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/assertion_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_designator.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_code.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_attribute_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_response_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_idp_list.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/server.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_name_identifier_mapping_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/debug.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_entry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_confirmation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/lasso.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/utils.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_register_name_identifier_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_x509_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_fault.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/keyprivate.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/federation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_proxy_restriction.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_requested_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_action.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_confirmation_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_locality.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/login.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_key_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/name_identifier_mapping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/logging.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_mapping_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_mapping_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/xml_enc.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_name_identifier.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_manage_name_id_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_base_idabstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_request_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/ecp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/export.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/xml_soap11.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_key_info_confirmation_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_request_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_request_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/saml2_helper.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_artifact_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_policy.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_request_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authentication_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/key.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/profile.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/profile.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/ctypes.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_list.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/misc_text_node.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_encrypted_element.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_register_name_identifier_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_xsd.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_name_identifier_mapping_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_status_code.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/xml_dsig.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/identity.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_advice.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_logout_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_authentication_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authn_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_authority_binding.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_header.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_one_time_use.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_manage_name_id_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_locality.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_condition_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_audience_restriction_condition.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/lecp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/errors.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_logout_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_response_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_name_id.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/session.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_logout_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authn_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_status.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/provider.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/backward_comp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/provider.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_artifact_resolve.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/defederation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_conditions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/name_registration.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_subject_query_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/registry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/xml.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_scoping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_scoping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_detail.h
lasso.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblasso.so.3.10.0 /lib64/libltdl.so.7
lasso.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblasso.so.3.10.0 /lib64/libdl.so.2
lasso.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblasso.so.3.10.0 /lib64/libm.so.6
lasso.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblasso.so.3.10.0 /lib64/libssl.so.10
lasso.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 147 errors, 9 warnings.
# echo 'rpmlint-done:'



Requires
--------
lasso-java (rpmlib, GLIBC filtered):
    jpackage-utils
    jre-gcj
    lasso
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    liblasso.so.3()(64bit)
    libltdl.so.7()(64bit)
    libm.so.6()(64bit)
    libssl.so.10()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.12)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxmlsec1-openssl.so.1()(64bit)
    libxmlsec1.so.1()(64bit)
    libxslt.so.1()(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

lasso-python (rpmlib, GLIBC filtered):
    lasso
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    liblasso.so.3()(64bit)
    libltdl.so.7()(64bit)
    libm.so.6()(64bit)
    libssl.so.10()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.12)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxmlsec1-openssl.so.1()(64bit)
    libxmlsec1.so.1()(64bit)
    libxslt.so.1()(64bit)
    libz.so.1()(64bit)
    python
    python(abi)
    rtld(GNU_HASH)

lasso-php (rpmlib, GLIBC filtered):
    config(lasso-php)
    lasso
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    liblasso.so.3()(64bit)
    libltdl.so.7()(64bit)
    libm.so.6()(64bit)
    libssl.so.10()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.12)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxmlsec1-openssl.so.1()(64bit)
    libxmlsec1.so.1()(64bit)
    libxslt.so.1()(64bit)
    libz.so.1()(64bit)
    php
    rtld(GNU_HASH)

lasso-doc (rpmlib, GLIBC filtered):

lasso-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    lasso
    liblasso.so.3()(64bit)
    pkgconfig(glib-2.0)
    pkgconfig(gobject-2.0)
    pkgconfig(libxml-2.0)
    pkgconfig(libxslt)
    pkgconfig(xmlsec1)

lasso (rpmlib, GLIBC filtered):
    /bin/sh
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libltdl.so.7()(64bit)
    libm.so.6()(64bit)
    libssl.so.10()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxmlsec1-openssl.so.1()(64bit)
    libxmlsec1.so.1()(64bit)
    libxslt.so.1()(64bit)
    libxslt.so.1(LIBXML2_1.0.11)(64bit)
    libz.so.1()(64bit)
    openssl
    rtld(GNU_HASH)
    xmlsec1
    xmlsec1-openssl



Provides
--------
lasso-java:
    lasso-java
    lasso-java(x86-64)
    libjnilasso.so()(64bit)

lasso-python:
    lasso-python
    lasso-python(x86-64)

lasso-php:
    config(lasso-php)
    lasso-php
    lasso-php(x86-64)

lasso-doc:
    lasso-doc
    lasso-doc(x86-64)

lasso-devel:
    lasso-devel
    lasso-devel(x86-64)
    pkgconfig(lasso)

lasso:
    lasso
    lasso(x86-64)
    liblasso.so.3()(64bit)



Unversioned so-files
--------------------
lasso-java: /usr/lib64/java/libjnilasso.so
lasso-php: /usr/lib64/php/modules/lasso.so
lasso-python: /usr/lib64/python2.7/site-packages/_lasso.so

Source checksums
----------------
http://dev.entrouvert.org/lasso/lasso-2.3.6.tar.gz :
  CHECKSUM(SHA256) this package     : 1895d2f33be64856f494c0b7590b9c6a5937023910e12748f89030fc0629be3e
  CHECKSUM(SHA256) upstream package : 1895d2f33be64856f494c0b7590b9c6a5937023910e12748f89030fc0629be3e


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1034387
Buildroot used: fedora-20-x86_64
Active plugins: Python, Shell-api, Generic, Java, C/C++
Disabled plugins: Ruby, R, SugarActivity, PHP, Perl
Disabled flags: EPEL5, EXARCH, DISTTAG

Comment 4 Nalin Dahyabhai 2013-11-26 18:51:09 UTC

Additional:

lasso-php is missing Requires: for php(zend-abi) = %{php_zend_api} and php(api) = %{php_core_api}, per https://fedoraproject.org/wiki/Packaging:PHP.

lasso-java may be putting the shared object in the wrong location (%{_libdir}/java vs %{_libdir}/%{name}), but I'd recommend checking with someone more familiar with Java packaging before changing it.

Comment 5 Simo Sorce 2013-11-26 23:18:11 UTC

I should have addressed most of the issues you raised here with this new set.
I removed the docs as I realized the current code fails to build the html stuff it was supposed to go in the -doc package, so better to supporess it for now and I will make sure upstream fixes it for the next official release.

Unfortunatley I am not sure all issues are fixed because my fedora-review (f20) tool does not return me the same results of yours, it return only a fraction of them.

I have not addressed the rpmlint complaints about FSF addrss being wrong, I will take a shot at it later, but I wanted to post current spec file to see if we are getting closer to pass the review given I can;t check that myself.

Spec URL: http://simo.fedorapeople.org/lasso/2/lasso.spec
SRPM URL: http://simo.fedorapeople.org/lasso/2/lasso-2.3.6-0.20131125.2.fc20.src.rpm

Comment 6 Simo Sorce 2013-11-27 18:18:55 UTC

Fixed the rmaining things I could find in a new version.
I have notified upstream of the bad fsf address in 780 files across sources.
Hopefully nothing major remains.

Spec URL: http://simo.fedorapeople.org/lasso/3/lasso.spec
SRPM URL: http://simo.fedorapeople.org/lasso/3/lasso-2.3.6-0.20131125.3.fc20.src.rpm

Comment 7 Nalin Dahyabhai 2013-12-02 21:26:45 UTC

Visible inspection of items previously noted:
* java subpackage now requires jpackage-utils, no longer requires python-lxml, which I assume means it was a typo after all -> OK
* not a blocker: javadoc not packaged
* the only docs that are packaged are AUTHORS/COPYING/NEWS/README ?
* package binaries are compiled using %{optflags} -> OK
* %post/%postun use -p /sbin/ldconfig to avoid a shell dependency -> OK
* license ("COPYING") is installed with base 'lasso' package -> OK
* subpackages which require base package do so using %{_isa} -> OK
* php subpackage owns %{_datadir}/php/%{name} -> OK
* debuginfo is available (spot-checked shared library and python binding) -> OK
* main package no longer includes specific Requires: -> OK
* %check section has been added -> OK

Other than the no-docs thing, it looks pretty good.  The timestamps on the header files don't seem to create problems installing both the 32- and 64-bit -devel subpackages on my development box, so we can skip that.  Do you plan on fixing the package to include more documentation?

The updated checklist:
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Packages have proper BuildRequires/Requires on jpackage-utils
- Javadoc documentation files are generated and included in -javadoc
  subpackage
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     * Unversioned so-files in private %_libdir subdirectory (see
       attachment) are binding plugins.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)",
     "Unknown or generated". 46 files have unknown license. Detailed output of
     licensecheck in /tmp/1034387-lasso/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/java
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/java
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
     * Still not clear on why exec_prefix needs to be passed to 'make install',
       but it doesn't break anything.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

Maven:
[-]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: Old add_to_maven_depmap macro is not being used

Python:
[-]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
     * Latest release + backport patches.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Packages are noarch unless they use JNI
     Note: lasso subpackage is not noarch.
[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: lasso-2.3.6-0.20131125.3.fc20.x86_64.rpm
          lasso-devel-2.3.6-0.20131125.3.fc20.x86_64.rpm
          lasso-java-2.3.6-0.20131125.3.fc20.x86_64.rpm
          lasso-php-2.3.6-0.20131125.3.fc20.x86_64.rpm
          lasso-python-2.3.6-0.20131125.3.fc20.x86_64.rpm
          lasso-2.3.6-0.20131125.3.fc20.src.rpm
lasso-devel.x86_64: W: no-documentation
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_confirmation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_rsa_key_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_entries.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_advice.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authn_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/tools.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/name_id_management.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_idp_entry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_terminate.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_body.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_detail.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_key_info_confirmation_data_type.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_evidence.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_conditions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_logout_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_extensions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_key_info.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_audience_restriction.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/logout.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authz_decision_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/registry-private.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_condition_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_status_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_federation_termination_notification.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authz_decision_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_assertion_id_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/assertion_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_designator.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_code.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_attribute_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_response_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_idp_list.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/server.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_name_identifier_mapping_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/debug.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_entry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_confirmation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/lasso.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/utils.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_register_name_identifier_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_x509_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_fault.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/keyprivate.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/federation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_proxy_restriction.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_requested_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_action.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_confirmation_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_locality.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/login.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_key_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/name_identifier_mapping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/logging.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_mapping_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_mapping_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/xml_enc.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_name_identifier.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_manage_name_id_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_base_idabstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_request_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/ecp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/export.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/xml_soap11.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_key_info_confirmation_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_request_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_request_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/saml2_helper.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_artifact_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_policy.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_request_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authentication_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/key.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/profile.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/profile.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/ctypes.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_list.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/misc_text_node.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_encrypted_element.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_register_name_identifier_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_xsd.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_name_identifier_mapping_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_status_code.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/xml_dsig.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/identity.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_advice.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_logout_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_authentication_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authn_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_authority_binding.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_header.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_one_time_use.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_manage_name_id_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_locality.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_condition_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_audience_restriction_condition.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/lecp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/errors.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_logout_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_response_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_name_id.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/session.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_logout_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authn_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_status.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/provider.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/backward_comp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/provider.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_artifact_resolve.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/defederation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_conditions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/name_registration.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_subject_query_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/registry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/xml.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_scoping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_scoping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_detail.h
lasso-java.x86_64: W: no-documentation
lasso-php.x86_64: W: no-documentation
lasso-python.x86_64: W: no-documentation
lasso.src:126: W: macro-in-comment %{_datadir}
lasso.src:134: W: macro-in-comment %{buildroot}
lasso.src:134: W: macro-in-comment %{_datadir}
6 packages and 0 specfiles checked; 146 errors, 7 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint lasso-devel lasso-java lasso-python lasso-php lasso
lasso-devel.x86_64: W: no-documentation
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_confirmation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_rsa_key_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_entries.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_advice.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authn_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/tools.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/name_id_management.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_idp_entry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_terminate.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_body.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_detail.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_key_info_confirmation_data_type.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_evidence.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_conditions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_logout_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_extensions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_key_info.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_audience_restriction.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/logout.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authz_decision_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/registry-private.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_condition_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_status_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_federation_termination_notification.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authz_decision_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_assertion_id_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/assertion_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_attribute_designator.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_code.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_attribute_query.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_response_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_idp_list.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/server.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_name_identifier_mapping_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/debug.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_entry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_confirmation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/lasso.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/utils.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_register_name_identifier_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_x509_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_fault.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/keyprivate.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/federation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_proxy_restriction.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_requested_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_action.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_confirmation_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_subject_locality.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/login.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/ds_key_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/name_identifier_mapping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/logging.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_mapping_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_mapping_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/xml_enc.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_name_identifier.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_manage_name_id_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_base_idabstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_request_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_statement_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/ecp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/export.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/xml_soap11.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_key_info_confirmation_data.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_request_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_request_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/saml2_helper.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_artifact_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_name_id_policy.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_request_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authentication_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/key.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/profile.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/profile.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/ctypes.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_idp_list.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/misc_text_node.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_encrypted_element.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_register_name_identifier_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_xsd.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_name_identifier_mapping_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_status_code.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/xml_dsig.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_assertion.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/identity.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_attribute_value.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_advice.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_logout_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_authentication_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_authn_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_authority_binding.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/soap-1.1/soap_header.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_one_time_use.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_manage_name_id_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_subject_locality.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_condition_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml_audience_restriction_condition.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/lecp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/errors.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_logout_response.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_response_envelope.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_name_id.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/session.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_logout_request.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authn_statement.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/samlp_status.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/dsig/strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/saml-2.0/provider.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/backward_comp.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/provider.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_artifact_resolve.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/defederation.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_strings.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_authn_context.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/saml2_conditions.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/id-ff/name_registration.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_subject_query_abstract.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/registry.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/xml.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_scoping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/lib_scoping.h
lasso-devel.x86_64: E: incorrect-fsf-address /usr/include/lasso/xml/saml-2.0/samlp2_status_detail.h
lasso-java.x86_64: W: no-documentation
lasso-python.x86_64: W: no-documentation
lasso-php.x86_64: W: no-documentation
lasso.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblasso.so.3.10.0 /lib64/libltdl.so.7
lasso.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblasso.so.3.10.0 /lib64/libdl.so.2
lasso.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblasso.so.3.10.0 /lib64/libm.so.6
lasso.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblasso.so.3.10.0 /lib64/libssl.so.10
5 packages and 0 specfiles checked; 146 errors, 8 warnings.
# echo 'rpmlint-done:'



Requires
--------
lasso-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    lasso(x86-64)
    liblasso.so.3()(64bit)
    pkgconfig(glib-2.0)
    pkgconfig(gobject-2.0)
    pkgconfig(libxml-2.0)
    pkgconfig(libxslt)
    pkgconfig(xmlsec1)

lasso-java (rpmlib, GLIBC filtered):
    jpackage-utils
    jre-gcj
    lasso(x86-64)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    liblasso.so.3()(64bit)
    libltdl.so.7()(64bit)
    libm.so.6()(64bit)
    libssl.so.10()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.12)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxmlsec1-openssl.so.1()(64bit)
    libxmlsec1.so.1()(64bit)
    libxslt.so.1()(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

lasso-python (rpmlib, GLIBC filtered):
    lasso(x86-64)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    liblasso.so.3()(64bit)
    libltdl.so.7()(64bit)
    libm.so.6()(64bit)
    libssl.so.10()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.12)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxmlsec1-openssl.so.1()(64bit)
    libxmlsec1.so.1()(64bit)
    libxslt.so.1()(64bit)
    libz.so.1()(64bit)
    python
    python(abi)
    rtld(GNU_HASH)

lasso-php (rpmlib, GLIBC filtered):
    /usr/bin/pecl
    config(lasso-php)
    lasso(x86-64)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    liblasso.so.3()(64bit)
    libltdl.so.7()(64bit)
    libm.so.6()(64bit)
    libssl.so.10()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.12)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxmlsec1-openssl.so.1()(64bit)
    libxmlsec1.so.1()(64bit)
    libxslt.so.1()(64bit)
    libz.so.1()(64bit)
    php(api)
    php(zend-abi)
    rtld(GNU_HASH)

lasso (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libltdl.so.7()(64bit)
    libm.so.6()(64bit)
    libssl.so.10()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxmlsec1-openssl.so.1()(64bit)
    libxmlsec1.so.1()(64bit)
    libxslt.so.1()(64bit)
    libxslt.so.1(LIBXML2_1.0.11)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)



Provides
--------
lasso-devel:
    lasso-devel
    lasso-devel(x86-64)
    pkgconfig(lasso)

lasso-java:
    lasso-java
    lasso-java(x86-64)
    libjnilasso.so()(64bit)

lasso-python:
    lasso-python
    lasso-python(x86-64)

lasso-php:
    config(lasso-php)
    lasso-php
    lasso-php(x86-64)

lasso:
    lasso
    lasso(x86-64)
    liblasso.so.3()(64bit)



Unversioned so-files
--------------------
lasso-java: /usr/lib64/java/libjnilasso.so
lasso-php: /usr/lib64/php/modules/lasso.so
lasso-python: /usr/lib64/python2.7/site-packages/_lasso.so

Source checksums
----------------
http://dev.entrouvert.org/lasso/lasso-2.3.6.tar.gz :
  CHECKSUM(SHA256) this package     : 1895d2f33be64856f494c0b7590b9c6a5937023910e12748f89030fc0629be3e
  CHECKSUM(SHA256) upstream package : 1895d2f33be64856f494c0b7590b9c6a5937023910e12748f89030fc0629be3e


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1034387
Buildroot used: fedora-20-x86_64
Active plugins: Python, Shell-api, Generic, Java, C/C++
Disabled plugins: Ruby, R, SugarActivity, PHP, Perl
Disabled flags: EPEL5, EXARCH, DISTTAG

Comment 8 Simo Sorce 2013-12-02 22:14:04 UTC

(In reply to Nalin Dahyabhai from comment #7)
> Visible inspection of items previously noted:
> * java subpackage now requires jpackage-utils, no longer requires
> python-lxml, which I assume means it was a typo after all -> OK
> * not a blocker: javadoc not packaged

There is no java documentation as far as I can see.

> * the only docs that are packaged are AUTHORS/COPYING/NEWS/README ?

Yes, for now.

> * package binaries are compiled using %{optflags} -> OK
> * %post/%postun use -p /sbin/ldconfig to avoid a shell dependency -> OK
> * license ("COPYING") is installed with base 'lasso' package -> OK
> * subpackages which require base package do so using %{_isa} -> OK
> * php subpackage owns %{_datadir}/php/%{name} -> OK
> * debuginfo is available (spot-checked shared library and python binding) ->
> OK
> * main package no longer includes specific Requires: -> OK
> * %check section has been added -> OK
> 
> Other than the no-docs thing, it looks pretty good.  The timestamps on the
> header files don't seem to create problems installing both the 32- and
> 64-bit -devel subpackages on my development box, so we can skip that.

Yes I thoink we can skip, upstream indicated the willingness to release a new version soon, so that will take care of the timestamps by requireing a lot less patching as well as the FSF Addrsss issue for which I sent a megapatch upstream.

> Do you plan on fixing the package to include more documentation?

No, not until upstream releases a new package. There are some issues in building the documentation, so I decided to punt on releaseing it in packages for now and defer to when the upstream package fixes some of it better.

Comment 9 Nalin Dahyabhai 2013-12-03 17:02:18 UTC

Then it looks to me that we're done here.  Setting fedora-review flag to '+'.

Comment 10 Gwyn Ciesla 2013-12-05 13:41:28 UTC

No SCM request found, clearing flag.

Comment 11 Simo Sorce 2013-12-05 13:47:18 UTC

(In reply to Jon Ciesla from comment #10)
> No SCM request found, clearing flag.

Argh, sorry, I wonder how I mangled this one.

Comment 12 Simo Sorce 2013-12-05 13:49:45 UTC

New Package SCM Request
=======================
Package Name: lasso
Short Description: Library that implements the Liberty alliance Single Sign On specification
Owners: simo
Branches: f20 f21
InitialCC:

Comment 13 Gwyn Ciesla 2013-12-05 14:45:19 UTC

Git done (by process-git-requests).

f21 not yet branched, and is still devel, which is automatic.

Comment 14 Simo Sorce 2013-12-05 19:08:15 UTC

Now built in rawhide, closing the review bug.