Bug 1034471

Summary: Diffing content specs/topics is buggy
Product: [Community] PressGang CCMS Reporter: Matthew Casperson <mcaspers>
Component: Web-UIAssignee: Lee Newson <lnewson>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.2CC: cbredesen
Target Milestone: ---   
Target Release: 1.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-23 23:43:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Matthew Casperson 2013-11-25 22:28:47 UTC
As you diff different revisions of the content specs, the actual revision that is shown is often not correct.

Diffing the latest and the second latest revisions will work (the first diff usually does), but if you then diff again you'll quite often get two revisions that you didn't select.

Comment 1 Lee Newson 2014-01-15 03:14:38 UTC
Additional Information:

This isn't just isolated to Content Specs, it also occurs with Topics. To replicate this you need to ensure you press the "Done" button, as you won't see the issue if you are clicking "Cancel".

Comment 2 Lee Newson 2014-01-15 03:36:59 UTC
Fixed in 1.4-SNAPSHOT build 201401151328

This was caused by swapping the sides the diff is displayed on for BZ#980695, however the "Done" button was missed and as such was saving the data from the left hand side when it should have been saving from the right hand side.

Note: This version is currently live on the test/development server.

Comment 3 Matthew Casperson 2014-01-27 23:22:51 UTC
When using the merge functionality to update the current revision with the differences in an old one such that both end up being identical, when "Done" is clicked the "Diff" button does not change to "Same Text" in the revision list.

Diffing again and clicking "Cancel" or "Done" does update the "Diff" and "Same Text" buttons.

Comment 4 Lee Newson 2014-01-28 01:54:57 UTC
Fixed in 1.4-SNAPSHOT build 201401281146

The revisions view wasn't being updated after the merge.

Note: This version is currently live on the test/development server.

Comment 5 Matthew Casperson 2014-01-28 03:49:31 UTC
Verified