Bug 1034563

Summary: systemd-fstab-generator dozens of complaints unable to fsck.btrfs during offline update
Product: [Fedora] Fedora Reporter: Chris Murphy <bugzilla>
Component: systemdAssignee: systemd-maint
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: jaroslav.pulchart, johannbg, lnykryn, msekleta, plautrba, systemd-maint, vpavlin, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-27 17:43:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
journalctl none

Description Chris Murphy 2013-11-26 06:25:37 UTC 
Description of problem:

During an offline update, systemd-fstab-generator wants to check rootfs but then can't find fsck.btrfs

Version-Release number of selected component (if applicable):
systemd-208-4

How reproducible:
Always

Steps to Reproduce:
1. Gnome/PK announced updates available.
2. Choose to restart and update.
3. During update the log reports many systemd-fstab-generator complaints

Actual results:
Checking was requested for /dev/disk/by-uuid/80a49dab-d435-402d-8228-02f884a1dfee, but /sbin/fsck.btrfs cannot be used: No such file or directory

Expected results:

From systemd I expect one such message, not dozens over and over again as if it's having a fit.

systemd-fstab-generator should honor /etc/fstab fs_passno for not checking file systems flagged with 0; OR it should be looking in the correct location for fsck.btrfs which in turn should be a no-op.



Additional info:
Bug 862871 might apply. Btrfs does not need fsck running in the first place, certainly not unattended.
Comment 1 Chris Murphy 2013-11-26 06:26:13 UTC 
Created attachment 829073 [details]
journalctl
Comment 2 Chris Murphy 2013-11-26 06:39:47 UTC 
OK so the bottom line for this bug is probably just that systemd-fstab-generator doesn't need to complain so many times about the lack of fsck.btrfs. And presumably systemd will respect /etc/fstab fs_passno?

In which case we need to get anaconda to correctly write the /etc/fstab for rootfs on Btrfs, which is still bug 862871.
Comment 3 Chris Murphy 2013-11-27 17:34:03 UTC 
Looks like this is fixed upstream:
http://cgit.freedesktop.org/systemd/systemd/commit/?id=94192cdaf652c9717f15274504ed315126c07a93
Comment 4 Zbigniew Jędrzejewski-Szmek 2013-11-27 17:43:07 UTC 
Yes, and included in systemd-208-6. Please reopen if additional changes are required.