Bug 1034585

Summary:	hot_deploy marker is at presence in the template repo of zend-6.1 apps
Product:	OpenShift Online	Reporter:	Zhe Wang <zhewang>
Component:	Image	Assignee:	Dan McPherson <dmcphers>
Status:	CLOSED NOTABUG	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	bmeng, david.l, dmcphers, vvitek, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-28 17:47:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Zhe Wang 2013-11-26 07:16:04 UTC

Description of problem:
There exists a hot_depoly marker by default after creating a zend-6.1 app, that is to say, hot deployment is enabled by default for zend-6.1 apps. It would be better that hot_deploy is configured by users purposely, or at least,  we should prompt messages about the presence of the hot_deploy marker to users when they create zend-6.1 apps.


Version-Release number of selected component (if applicable):
vvitek-Zend-QE-preserve

How reproducible:
always


Steps to Reproduce:
1. create a zend-6.1 app
2. ls $APP_REPO/.openshift/markers/
3. create an empty file and trigger a build

Actual results:
In step 2, we can see that there is a hot_deploy marker which is not created by users, and hot deployment is enabled during the build in Step 3:

Total 8 (delta 0), reused 0 (delta 0)
remote: Not stopping cartridge zend because hot deploy is enabled

Expected results:
It would be better that hot_deploy is configured by users, or we should prompt messages about the presence of the hot_deploy marker to users when they create zend-6.1 apps.

Additional info:

Comment 1 Vojtech Vitek 2013-11-26 14:58:46 UTC

This is imho NOTABUG.

Zend strongly demand the hot_deploy marker enabled by default, as they don't want the whole Zend Server to get restarted every time on deploy. They actually use their own deployment daemon to handle restarts of php processes, if needed (because of PHP.INI configuration changes).

Dan, what do you think? Can we have hot_deploy enabled by default in zend cartridge?

Comment 2 David Lowes - Zend 2013-11-28 16:58:13 UTC

I added the hot_deploy marger on purpose since PHP applications do not normally require restarts to function properly. Most PHP app developers make small changes frequently and such restarts might cause them to abandon the product. When a user makes changes that require restart Zend Server performs the restart (or informs the user that it is required).