Bug 1034751

Summary:	Modify the error messages for multicast port validation to be more specific
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Petr Kremensky <pkremens>
Component:	Installer	Assignee:	Francisco Canas <fcanas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Petr Kremensky <pkremens>
Severity:	low	Docs Contact:	Russell Dickenson <rdickens>
Priority:	unspecified
Version:	6.3.0	CC:	fcanas, thauser
Target Milestone:	ER4
Target Release:	EAP 6.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-28 15:38:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Petr Kremensky 2013-11-26 13:12:32 UTC

Description of problem:
If user fails the port validation of eg. "ajp" port, the message on error dialog says "Port number for ajp must be an integer within the range 1-65535.". This clearly indicates which input field must be changed. However if user fails the validation of any Multicast-port, the general error message is shown "Port number for multicast-port must be an integer within the range 1-65535." giving user no indication which one of multicast-port fields is wrong.

Version-Release number of selected component (if applicable):
 EAP 6.2.0.CR3

How reproducible:
 Always

Steps to Reproduce:
 1. Start the gui installation, go to Socket bindings screen using default values. 
 2. Choose to "Configure custom port bindings." and "Configure ports for standalone mode", continue to Socket Binding (ha-standalone) screen.
 3. Enter "77777" to jgroups-mping Multicast-Port and press next.

Actual results:
 "Port number for multicast-port must be an integer within the range 1-65535."

Expected results:
 "Port number for jgroups-mping multicast-port must be an integer within the range 1-65535."

Affected fields:
standalone-ha:
 - jgroups-mping Multicast-Port
 - jgroups-udp Multicast-Port
 - modcluster Multicast-Port
standalone-full:
 - messaging-group Multicast-Port
standalone-full-ha:
 - jgroups-mping Multicast-Port
 - jgroups-udp Multicast-Port
 - modcluster Multicast-Port
 - messaging-group Multicast-Port
domain-ha:
 - jgroups-mping Multicast-Port
 - jgroups-udp Multicast-Port
 - modcluster Multicast-Port
domain-full:
 - messaging-group Multicast-Port
domain-full-ha:
 - jgroups-mping Multicast-Port
 - jgroups-udp Multicast-Port
 - messaging-group Multicast-Port
 - modcluster Multicast-Port

Comment 1 Francisco Canas 2013-11-26 18:57:47 UTC

Fixed the error messages. Multicast port validator displays the expected error now, with the port name shown.

http://git.app.eng.bos.redhat.com/jbossas-installer.git/commit/?h=eap-6.2&id=b1ddfe5233866882531fd6a5a7d82b44dfa02528

Comment 2 Petr Kremensky 2014-04-16 13:41:17 UTC

This is fixed in EAP 6.3.0.ER1. 

Please move all relevant BZs to ON_QA so I can verify them.

Comment 3 Petr Kremensky 2014-04-16 13:59:50 UTC

I see one problem here. Going through example from description, installer uses same message for port number overlap, and for empty input.

Actual:
Enter 77777 into jgroups-mping-Multicast-Port
message - Please enter a port number for jgroups-mping multicast-port.
Enter "" into jgroups-mping-Multicast-Port
message - Please enter a port number for jgroups-mping multicast-port.

Expected:
Enter 77777 into jgroups-mping-Multicast-Port
message - Port number for jgroups-mping multicast-port must be an integer within the range 1-65535..
Enter "" into jgroups-mping-Multicast-Port
message - Please enter a port number for jgroups-mping multicast-port.

and so on with other fields from description

Comment 4 Francisco Canas 2014-04-16 17:55:11 UTC

I've corrected the validator messages for the ports in the BZ description.

http://git.app.eng.bos.redhat.com/git/eap-installer.git/commit/?id=fde0eee5bcfb06e5c3e786ea43db8d5964958703

Comment 5 Petr Kremensky 2014-04-24 13:03:33 UTC

The problesm from comment 3 are now fixed, but original issue from description still last. 

All messages are now correct if user enters empty value into any of field in Socket screen.

These are my results for port overlap & invalid IP format messages:
---   standalone-full   ---
 - wrong label in Error dialog message for: messaging-group Multicast-Port
   - EXPECTED: "Port number for messaging-group multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."

---   standalone-ha   ---
 - wrong label in Error dialog message for: jgroups-mping Multicast-Port
   - EXPECTED: "Port number for jgroups-mping multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: jgroups-udp Multicast-Port
   - EXPECTED: "Port number for jgroups-udp multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: modcluster Multicast-Port
   - EXPECTED: "Port number for modcluster multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."

---   standalone-full-ha   ---
 - wrong label in Error dialog message for: jgroups-mping Multicast-Port
   - EXPECTED: "Port number for jgroups-mping multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: jgroups-udp Multicast-Port
   - EXPECTED: "Port number for jgroups-udp multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: modcluster Multicast-Port
   - EXPECTED: "Port number for modcluster multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: messaging-group Multicast-Port
   - EXPECTED: "Port number for messaging-group multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."

---   domain-full   ---
 - wrong label in Error dialog message for: messaging-group Multicast-Port
   - EXPECTED: "Port number for messaging-group multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."

---   domain-ha   ---
 - wrong label in Error dialog message for: jgroups-mping Multicast-Port
   - EXPECTED: "Port number for jgroups-mping multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: jgroups-udp Multicast-Address
   - EXPECTED: "Address is not IPv4 / IPv6 compliant. Please check the address for jgroups-udp."
   - ACTUAL  : "Address is not IPv4 / IPv6 compliant. Please check the address for multicast."
 - wrong label in Error dialog message for: jgroups-udp Multicast-Port
   - EXPECTED: "Port number for jgroups-udp multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: modcluster Multicast-Port
   - EXPECTED: "Port number for modcluster multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."

---   domain-full-ha   ---
 - wrong label in Error dialog message for: jgroups-mping Multicast-Port
   - EXPECTED: "Port number for jgroups-mping multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: jgroups-udp Multicast-Address
   - EXPECTED: "Address is not IPv4 / IPv6 compliant. Please check the address for jgroups-udp."
   - ACTUAL  : "Address is not IPv4 / IPv6 compliant. Please check the address for multicast."
 - wrong label in Error dialog message for: jgroups-udp Multicast-Port
   - EXPECTED: "Port number for jgroups-udp multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: messaging-group Multicast-Port
   - EXPECTED: "Port number for messaging-group multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."
 - wrong label in Error dialog message for: modcluster Multicast-Port
   - EXPECTED: "Port number for modcluster multicast-port must be an integer within the range 1-65535."
   - ACTUAL  : "Port number for multicast-port must be an integer within the range 1-65535."

Comment 6 Francisco Canas 2014-04-24 18:58:37 UTC

Sorry about that, Petr. To correctly fix the message I had to modify Izpack's userInputPanel.

See commits:
http://git.app.eng.bos.redhat.com/git/izpack.git/commit/?id=633f9d434ca2361627507b8cc6ca81684e24944e
and 
http://git.app.eng.bos.redhat.com/git/eap-installer.git/commit/?id=75bd360c3199b4d38ec57e78722a904a536358ba

Multicast-ports should now display both messages correctly, for invalid ranges and for a blank field.

Comment 7 Petr Kremensky 2014-04-25 07:14:15 UTC

No problem, I'll retest with next ER build.

Comment 8 Petr Kremensky 2014-05-07 12:41:33 UTC

There is one more message that should be fixed. The rest of issues is fixed now.

Use some invalid IP address for jgroups-udp Multicast-Address on: 
 - Socket Binding (ha-domain)
 - Socket Binding (full-ha-domain)


 - EXPECTED: "Address is not IPv4 / IPv6 compliant. Please check the address for jgroups-udp."
 - ACTUAL  : "Address is not IPv4 / IPv6 compliant. Please check the address for multicast."

Comment 9 Francisco Canas 2014-05-07 13:24:24 UTC

Fixed the message id's for both of the above ports:

http://git.app.eng.bos.redhat.com/git/eap-installer.git/commit/?id=72eed45e851a373060db8c257830732efa012a1e

Comment 10 Petr Kremensky 2014-05-15 06:41:17 UTC

Verified on EAP 6.3.0.ER4 installer.