Bug 1035245

Summary:	midori-0.5.6 missing nojs icons in the package
Product:	[Fedora] Fedora	Reporter:	Branko Grubić <bitlord0xff>
Component:	midori	Assignee:	Kevin Fenzi <kevin>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	kevin
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	midori-0.5.7-1.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-26 00:32:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Branko Grubić 2013-11-27 11:18:36 UTC

Description of problem:
After upgrade from 0.5.5 to 0.5.6 everything worked well, no issues, but later I saw that icon for 'nojs' extension is missing. 

Version-Release number of selected component (if applicable):
midori-0.5.6-1.fc20.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
missing nojs icons in the bottom panel (statusbar?), "generic" icon is shown

Expected results:
regular nojs icon/s are shown

Additional info:
I downloaded source package and icons are still there, but I don't know much how to check if it is a build system problem (upstream) or a packaging issue (fedora). In source tarball icons are located 'midori-0.5.6/data/nojs/' 

midori-0.5.6-1.fc20 ( rpm -ql midori | grep -i js ) 
[root@localhost ~]# rpm -ql midori | grep -i js
/usr/lib64/midori/libnojs.so
/usr/share/midori/res/autosuggestcontrol.js


midori-0.5.5-2.fc20 ( rpm -ql midori | grep -i js )
[root@localhost ~]# rpm -ql midori | grep -i js
/usr/lib64/midori/libnojs.so
/usr/share/midori/res/autosuggestcontrol.js
/usr/share/midori/res/nojs
/usr/share/midori/res/nojs/nojs-statusicon-allowed.png
/usr/share/midori/res/nojs/nojs-statusicon-denied.png
/usr/share/midori/res/nojs/nojs-statusicon-mixed.png

Comment 1 Kevin Fenzi 2013-11-30 20:13:50 UTC

I can definitely confirm this. cmake just doesn't seem to be installing those files as part of 'make install'. 

Filed https://bugs.launchpad.net/midori/+bug/1256562 about it.

Comment 2 Fedora Update System 2014-01-18 04:04:04 UTC

midori-0.5.7-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/midori-0.5.7-1.fc20

Comment 3 Fedora Update System 2014-01-19 04:03:55 UTC

Package midori-0.5.7-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing midori-0.5.7-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-1111/midori-0.5.7-1.fc20
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2014-01-26 00:32:32 UTC

midori-0.5.7-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.