Bug 1035314

Summary: vdsm-hook-nestedvt uses kvm_intel-only syntax
Product: [Retired] oVirt Reporter: Sander <bugzilla>
Component: vdsmAssignee: Michal Skrivanek <michal.skrivanek>
Status: CLOSED CURRENTRELEASE QA Contact: Lukas Svaty <lsvaty>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.3CC: acathrow, bazulay, bugs, danken, iheim, mavital, mgoldboi, sbonazzo, yeylon
Target Milestone: ---Keywords: EasyFix
Target Release: 3.4.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: virt
Fixed In Version: ovirt-3.4.0-beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-31 12:23:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch that uses the right nestedvt flag on AMD-based systems. none

Description Sander 2013-11-27 14:24:15 UTC
Created attachment 829764 [details]
Patch that uses the right nestedvt flag on AMD-based systems.

Description of problem:

vdsm-hook-nestedvt uses kvm_intel-only syntax

Version-Release number of selected component (if applicable):

All versions that I checked.

How reproducible:

Use an amd-based node with oVirt and try to use nested virtualization.

Steps to Reproduce:
1. Install vdsm-hook-nestedvt on AMD-based oVirt node.
2. Start VM
3. Look in the vdsm log for the generated VM XML

Actual results:
No svm flag is added to cpu definition.

Expected results:
An svm flag is added to cpu definition.

Additional info:

kvm_amd uses "1" for it's nested flag, kvm_intel uses "Y"

Attached is a simple patch that fixes the behaviour on my systems.

Comment 1 Itamar Heim 2014-01-12 08:41:45 UTC
setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc.

Comment 3 Sandro Bonazzola 2014-01-27 13:47:13 UTC
This should be fixed in 3.4.0 beta1

Comment 4 Lukas Svaty 2014-02-27 13:26:07 UTC
verified in beta3

vm cpu definition:
<cpu match="exact">
  <model>Opteron_G2</model>
  <topology cores="1" sockets="160" threads="1"/>
<feature name="svm" policy="require"/></cpu>

Comment 5 Sandro Bonazzola 2014-03-31 12:23:43 UTC
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released