Bug 1035349

Summary: Improvements needed in section '4.5.6. Dynamic Analyzer Selection'
Product: [JBoss] JBoss Data Grid 6 Reporter: Adrian Nistor <anistor>
Component: DocumentationAssignee: Misha H. Ali <mhusnain>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: anistor, jdg-bugs
Target Milestone: GA   
Target Release: 6.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-16 00:02:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Adrian Nistor 2013-11-27 15:34:43 UTC 
Under the mentioned section, specifically in 'Procedure 4.3. Configure the @AnalyzerDiscriminator':

 - the code snippet from step 1 is repeated in step 2. We could have only one code snippet box shared between steps 1, 2.

 - the code snippet from step 3 should not repeat the definition of BlongEntry class previously defined. Should only contain the defition of LanguageDiscriminator class

 - the line "// standard getter/setter    ...}" was probably inteded to split in 3 separate lines, so the class definition is properly ended with "}"

 - step 3 "Implement the getAnalyzerDefinitionName() Method" should actually be called "Implement the Discriminator interface"
Comment 2 Misha H. Ali 2013-11-28 06:24:25 UTC 
(In reply to Adrian Nistor from comment #0)
> Under the mentioned section, specifically in 'Procedure 4.3. Configure the
> @AnalyzerDiscriminator':
> 
>  - the code snippet from step 1 is repeated in step 2. We could have only
> one code snippet box shared between steps 1, 2.

Done, steps 1 and 2 are merged and share one snippet box.

>  - the code snippet from step 3 should not repeat the definition of
> BlongEntry class previously defined. Should only contain the defition of
> LanguageDiscriminator class

Done.

>  - the line "// standard getter/setter    ...}" was probably inteded to
> split in 3 separate lines, so the class definition is properly ended with "}"

Now split.

>  - step 3 "Implement the getAnalyzerDefinitionName() Method" should actually
> be called "Implement the Discriminator interface"

Also fixed.

Adrian, can you confirm the changes are correct or let me know if there should be further changes.
Comment 3 Adrian Nistor 2013-11-28 14:27:11 UTC 
Please add an empty line before "// standard getter/setter".

The rest is fine. Can be closed. Thanks!
Comment 4 Misha H. Ali 2013-11-28 23:37:27 UTC 
Fixed and closing as per Adrian's OK.
Comment 5 Misha H. Ali 2014-01-16 00:02:51 UTC 
The fix for this bug is now generally released and available here:

https://access.redhat.com/site/documentation/en-US/Red_Hat_JBoss_Data_Grid/6.2/index.html