| Summary: | Review Request: mod_auth_mellon - A SAML 2.0 authentication module for the Apache Httpd Server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Simo Sorce <ssorce> |
| Component: | Package Review | Assignee: | Rob Crittenden <rcritten> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | michele, package-review, rcritten, sgallagh |
| Target Milestone: | --- | Flags: | rcritten:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-11 16:17:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Simo Sorce
2013-11-27 22:56:44 UTC
Note that this package depends on the lasso library. The review for lasso is here: https://bugzilla.redhat.com/show_bug.cgi?id=1034387 To review this package you can do the following: $ fedora-review -b 1034387 $ fedora-review -b 1035499 The first review will build and install the lasso library in your mock chroot and make the dependency available in your mock environment to review mod_auth_mellon. - Can you notify upstream about the new FSF address? The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. - You set MellonLockFile "/run/mod_auth_mellon/lock" in the config, but I am not sure who creates /run/mod_auth_mellon (could not see that in the code) or if it should be package owned. Can you check that? (In reply to Michele Baldessari from comment #2) > - Can you notify upstream about the new FSF address? > The Free Software Foundation address in this file seems to be outdated or > misspelled. Ask upstream to update the address, or if this is a license > file, > possibly the entire file with a new copy available from the FSF. Sigh, again, (just sent a mega patch for lasso to fix this :) > - You set MellonLockFile "/run/mod_auth_mellon/lock" in the config, but I am > not sure who creates /run/mod_auth_mellon (could not see that in the code) or > if it should be package owned. Can you check that? See Source3, it is a tmpfiles.d configuration file that creates /run/mod_auth_mellon at startup. lasso is now built in rawhide, so I am dropping the dependency. You need to own the tmpfiles.d directory per https://fedoraproject.org/wiki/Packaging:Tmpfiles.d with this in %files: %dir /run/%{name}/ Otherwise looks ok. Fixed /run/ directory ownership: Spec URL: http://simo.fedorapeople.org/mod_auth_mellon/1/mod_auth_mellon.spec SRPM URL: http://simo.fedorapeople.org/mod_auth_mellon/1/mod_auth_mellon-0.7.0-1.fc20.src.rpm Fix looks good, approved. New Package SCM Request ======================= Package Name: mod_auth_mellon Short Description: A SAML 2.0 authentication module for the Apache Httpd Server Owners: simo Branches: f20 InitialCC: Git done (by process-git-requests). Built in Rawhide, thanks a lot to everyone involved. |