Bug 1035824

Summary:	Automember betxnpreoperation - transaction not aborted when group entry does not exist
Product:	Red Hat Enterprise Linux 7	Reporter:	Ján Rusnačko <jrusnack>
Component:	389-ds-base	Assignee:	Rich Megginson <rmeggins>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sankar Ramalingam <sramling>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	mkubik, mreynolds, nhosoi, nkinder
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	389-ds-base-1.3.1.6-12.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-13 11:32:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ján Rusnačko 2013-11-28 15:05:19 UTC

Description of problem:
From RHEL 7 most DS plugins are converted to be betxn - if their operation fails, whole transaction should fail and not be comitted to database. In case of Auto Membership plugin, we can create a situation where plugin fails to add user to group, e.g. due to non-existent group entry.

Version-Release number of selected component (if applicable):
389-ds-base-1.3.1.6-8.el7.x86_64

How reproducible:
always

Steps to Reproduce:
1. Add definition entry:
ldapmodify -D "cn=directory manager" -w Secret123 -a <<EOF
dn: cn=testGroup,cn=Auto Membership Plugin,cn=plugins,cn=config
objectclass: autoMemberDefinition
autoMemberScope: ou=People,dc=example,dc=com
autoMemberFilter: cn=tuser
autoMemberDefaultGroup: cn=testgroup,ou=groups,dc=example,dc=com
autoMemberGroupingAttr: member:dn
EOF

Make sure cn=testgroup,ou=groups,dc=example,dc=com does not exist.

2. Add user:
ldapmodify -D "cn=directory manager" -w Secret123 -a <<EOF
dn: cn=tuser,ou=people,dc=example,dc=com
objectclass: person
objectclass: top
cn: tuser
sn: tuser
EOF

The operation is successful:
[jrusnack@localhost 6.0]$ ldapsearch -LLL -h localhost -p 34368 -D "cn=directory manager" -w Secret123 -b "cn=tuser,dc=autoMembers,dc=com"
dn: cn=tuser,dc=autoMembers,dc=com
objectClass: person
objectClass: top
cn: tuser
sn: tuser

Actual results:
[jrusnack@localhost 6.0]$ tail -n1 /var/log/dirsrv/slapd-dstet/errors
[28/Nov/2013:07:55:17 -0700] auto-membership-plugin - automember_add_member_value: Unable to add "cn=tuser,dc=automembers,dc=com" as a "member" value to group "cn=testgroup,dc=autoMembers,dc=com" (No such object).


Expected results:
User should not be added, if plugin operation fails.

Comment 2 Nathan Kinder 2013-12-09 15:56:47 UTC

Upstream ticket:
https://fedorahosted.org/389/ticket/47622

Comment 3 mreynolds 2013-12-10 15:03:50 UTC

Fixed upstream

Comment 5 Milan Kubík 2014-01-31 15:24:09 UTC

ldapsearch -D "cn=directory manager" -w Secret123 -LLL -b "cn=testgroup,ou=groups,o=my.com"
No such object (32)
Matched DN: ou=groups,o=my.com

ldapmodify -D "cn=directory manager" -w Secret123 -a <<EOF
dn: cn=testGroup,cn=Auto Membership Plugin,cn=plugins,cn=config
objectclass: autoMemberDefinition
autoMemberScope: ou=People,o=my.com
autoMemberFilter: cn=tuser
autoMemberDefaultGroup: cn=testgroup,ou=groups,o=my.com
autoMemberGroupingAttr: member:dn
EOF
adding new entry "cn=testGroup,cn=Auto Membership Plugin,cn=plugins,cn=config"

ldapmodify -D "cn=directory manager" -w Secret123 -a <<EOF
dn: cn=tuser,ou=people,o=my.com
objectclass: person
objectclass: top
cn: tuser
sn: tuser
EOF
adding new entry "cn=tuser,ou=people,o=my.com"
ldap_add: Server is unwilling to perform (53)
        additional info: Automember Plugin update unexpectedly failed.

ldapsearch -D "cn=directory manager" -w Secret123 -LLL -b "cn=testuser,ou=people,o=my.com"
No such object (32)
Matched DN: ou=people,o=my.com

Tested on 389-ds-base-1.3.1.6-17.el7

Comment 7 Ludek Smid 2014-06-13 11:32:18 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.