| Summary: | [abrt] cinnamon-2.0.11-1.fc19: cinnamon-desktop-editor.py:104:pick_icon:AttributeError: 'NoneType' object has no attribute 'get_filename' | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miguel Angel Perez <mangelp> | ||||||
| Component: | cinnamon | Assignee: | leigh scott <leigh123linux> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 19 | CC: | dan.mashal, dgallowa, fedora, joshua.bakerlepain, kmsmgill, leigh123linux | ||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Unspecified | ||||||||
| URL: | https://retrace.fedoraproject.org/faf/reports/bthash/02890be4bb26477c461992431a17abaa9dd35de6 | ||||||||
| Whiteboard: | abrt_hash:1fbce37da3a07e9ce84bd67b7904671c6c9e5f80 | ||||||||
| Fixed In Version: | cinnamon-2.0.14-15.fc19 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-03-15 15:07:00 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
Created attachment 830922 [details]
File: backtrace
Created attachment 830923 [details]
File: environ
As the error exists in Cinnamon 2.0.4, (F20, x86_64) condition can be fixed by replacing line 104 of /usr/lib/cinnamon-desktop-editor/cinnamon-desktop-editor.py with icon_info_fn = icon_info.get_filename() if icon_info != None else None Reason: If no icon is configured (as is the case for new launchers), the previous lookup_icon will fail returning None. As it is, the code assumed a valid value for icon_info and attempts to extract the filename. This fix simply adds a check as to whether icon_info is None. If icon_info is null it assigns None to icon_info_fn and the method carries on as designed. This message is a reminder that Fedora 18 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 18. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '18'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 18's end of life. Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 18 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior to Fedora 18's end of life. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. I'd like to request this be re-opened. This occurs in 3.12.11-201.fc19.x86_64 with cinnamon-2.0.14-4.fc19.x86_64 (In reply to Kevin Gill from comment #3) > As the error exists in Cinnamon 2.0.4, (F20, x86_64) condition can be fixed > by replacing line 104 of > /usr/lib/cinnamon-desktop-editor/cinnamon-desktop-editor.py with > > icon_info_fn = icon_info.get_filename() if icon_info != None else None > > Reason: If no icon is configured (as is the case for new launchers), the > previous lookup_icon will fail returning None. As it is, the code assumed a > valid value for icon_info and attempts to extract the filename. This fix > simply adds a check as to whether icon_info is None. If icon_info is null it > assigns None to icon_info_fn and the method carries on as designed. Confirmed this fixed it on F19 for me. Thanks Kevin. *** Bug 1073066 has been marked as a duplicate of this bug. *** *** Bug 1064021 has been marked as a duplicate of this bug. *** cinnamon-2.0.14-15.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/cinnamon-2.0.14-15.fc19 cinnamon-2.0.14-15.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/cinnamon-2.0.14-15.fc20 Package cinnamon-2.0.14-15.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing cinnamon-2.0.14-15.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-3545/cinnamon-2.0.14-15.fc19 then log in and leave karma (feedback). cinnamon-2.0.14-15.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. cinnamon-2.0.14-15.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Add a new launcher to the toolbar for a program (argouml in my case). When you are editing the launch properties click on the image icon to set an image, then the error happens. Version-Release number of selected component: cinnamon-2.0.11-1.fc19 Additional info: reporter: libreport-2.1.9 cmdline: python /usr/lib/cinnamon-desktop-editor/cinnamon-desktop-editor.py -mpanel-launcher executable: /usr/lib/cinnamon-desktop-editor/cinnamon-desktop-editor.py kernel: 3.11.8-200.fc19.x86_64 runlevel: N 5 type: Python uid: 1000 Truncated backtrace: cinnamon-desktop-editor.py:104:pick_icon:AttributeError: 'NoneType' object has no attribute 'get_filename' Traceback (most recent call last): File "/usr/lib/cinnamon-desktop-editor/cinnamon-desktop-editor.py", line 104, in pick_icon icon_info_fn = icon_info.get_filename() AttributeError: 'NoneType' object has no attribute 'get_filename' Local variables in innermost frame: self: <__main__.IconPicker object at 0x1387bd0> chooser: <FileChooserDialog object at 0x14024b0 (GtkFileChooserDialog at 0x16723e0)> theme: <IconTheme object at 0x1402460 (GtkIconTheme at 0x15a55e0)> button: <Button object at 0x13da500 (GtkButton at 0x15322c0)> fn: 'gnome-panel-launcher' icon_info: None