Bug 1036507

Summary: Should give a meaningful message when creating one app with an invalid manifest file
Product: OpenShift Online Reporter: zhaozhanqi <zzhao>
Component: PodAssignee: Rajat Chopra <rchopra>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: abhgupta, xtian
Target Milestone: ---Keywords: Regression
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1062844 (view as bug list) Environment:
Last Closed: 2014-02-26 19:08:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1062844    
Attachments:
Description Flags
development.log none

Description zhaozhanqi 2013-12-02 07:54:19 UTC 
Description of problem:
Creating one app with an invalid manifest file, the message prompted is not clearly.

Version-Release number of selected component (if applicable):
devenv_4084

How reproducible:
always

Steps to Reproduce:
1. Creating one app with an invalid manifest file
rhc app-create testappa https://s3-eu-west-1.amazonaws.com/cpg.openshift.cartridges/bugrepro/diy-cart/manifffest.yml

Actual results:
rhc app-create testappa https://s3-eu-west-1.amazonaws.com/cpg.openshift.cartridges/bugrepro/diy-cart/manifffest.yml
The cartridge 'https://s3-eu-west-1.amazonaws.com/cpg.openshift.cartridges/bugrepro/diy-cart/manifffest.yml' will be downloaded and installed

Application Options
-------------------
Domain:     zqd
Cartridges: https://s3-eu-west-1.amazonaws.com/cpg.openshift.cartridges/bugrepro/diy-cart/manifffest.yml
Gear Size:  default
Scaling:    no

Creating application 'testappa' ... 
Unable to complete the requested operation due to: unexpected response: #<HTTP::Message::Headers:0x0000000758f6b8 @http_version="1.1", @body_size=0, @chunked=false, @request_method="GET", @request_uri=#<URI::HTTPS:0x0000000758fc80
URL:https://s3-eu-west-1.amazonaws.com/cpg.openshift.cartridges/bugrepro/diy-cart/manifffest.yml>, @request_query=nil, @request_absolute_uri=nil, @status_code=404, @reason_phrase="Not Found", @body_type=nil, @body_charset=nil,
@body_date=nil, @body_encoding=#<Encoding:ASCII-8BIT>, @is_request=false, @header_item=[["x-amz-request-id", "634736BE522B8F90"], ["x-amz-id-2", "504nXjnMtk7C1oBWfVEy2D4QCzKPVM4+vuROGI6JlU4wk+VQRraIIxBkQuM76oZN"], ["Content-Type",
"application/xml"], ["Transfer-Encoding", "chunked"], ["Date", "Mon, 02 Dec 2013 06:47:08 GMT"], ["Server", "AmazonS3"]], @dumped=false>.
Reference ID: 2d23328b5b9f0e831203a8d9e5273ded


Expected results:
Should give a meaningful message like: 

Creating application 'testapp' ... Invalid manifest file from url 'https://s3-eu-west-1.amazonaws.com/cpg.openshift.cartridges/bugrepro/diy-cart/manifffest.yml'

Additional info:
Comment 1 zhaozhanqi 2013-12-02 07:55:08 UTC 
Created attachment 831468 [details]
development.log
Comment 2 Abhishek Gupta 2013-12-02 18:52:30 UTC 
Do we handle 404s (missing manifest files)?
Comment 3 Rajat Chopra 2013-12-03 22:23:38 UTC 
Fixed with https://github.com/openshift/origin-server/pull/4281
Comment 4 zhaozhanqi 2013-12-04 09:17:33 UTC 
Tested this bug on devenv_4093, it has been fixed

Creating application 'testappa' ... Bad response (404) from url - https://s3-eu-west-1.amazonaws.com/cpg.openshift.cartridges/bugrepro/diy-cart/manifffest.yml

mark it to 'verified'