Bug 1036652

Summary: Apply upstream patch to prevent rgmanager crash on misconfigured "time_t" values (e.g., __restart_expire_time) in cluster.conf
Product: Red Hat Enterprise Linux 6 Reporter: Jan Pokorný [poki] <jpokorny>
Component: rgmanagerAssignee: Ryan McCabe <rmccabe>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: high    
Version: 6.4CC: cluster-maint, mjuricek
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rgmanager-3.0.12.1-20.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-14 08:12:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Pokorný [poki] 2013-12-02 12:40:27 UTC 
Looks like relatively old upstream commit [1] hasn't reached RHEL
downstream yet.  Note that the respective bug/fix was also discussed
in the security context as of its time (that's why medium pri/sev);
reproducer example from the original discussion involving me, Lon, Ryan,
and secalert@ (test-expand-time is the part of the patch, and can be
compiled separately in order to test verify the issue):

> Btw. here is a demonstration of the issue with the test program      
> that was part of the posted patch (but here resrules.c is unpatched):
>                                                                      
> $ ./test-expand-time                                                 
> Time string: 0                                                       
> Expanded   : 0                                                       
> Time string: 000000000000000                                         
> Expanded   : 0                                                       
> Time string: 0000000000000000                                        
> Expanded   : 0                                                       
> Time string: 00000000000000000                                       
> Expanded   : 0                                                       
> Time string: 000000000000000000                                      
> Expanded   : 0                                                       
> Time string: 0000000000000000000                                     
> Expanded   : 0                                                       
> Time string: 00000000000000000000                                    
> Expanded   : 0                                                       
> Time string: 000000000000000000000                                   
> Expanded   : 0                                                       
> Time string: 0000000000000000000000                                  
> Expanded   : 0                                                       
> Time string: 00000000000000000000000                                 
> Expanded   : 0                                                       
> Time string: 000000000000000000000000                                
> Expanded   : 0                                                       
> Time string: 0000000000000000000000000                               
> Expanded   : 0                                                       
> Segmentation fault                                                   

This should definitely go into 6.6.

[1] https://git.fedorahosted.org/cgit/cluster.git/commit/?id=9d0ecbac1ff8ac1f045bd19bb73ca063a5351014
Comment 3 errata-xmlrpc 2014-10-14 08:12:31 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1586.html