Bug 1036780

Summary: rabbitmq-server wrapper script drops arguments
Product: [Fedora] Fedora Reporter: Robert Buchholz <rbu>
Component: rabbitmq-serverAssignee: Peter Lemenkov <lemenkov>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: erlang, hubert.plociniczak, lemenkov, plemenko, tis
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Improved and greatly simplified wrapper none

Description Robert Buchholz 2013-12-02 15:38:04 UTC
Description of problem:
the wrapper script /usr/sbin/rabbitmqctl drops all arguments to the command in certain cases, for example when the calling user is not root.

I am running a rabbitmq node as a local user (for development) as a regular user, outside of /var. This works fine, however the Fedora-specific wrapper to "rabbitctl" will obscure access to the rabbitctl script. It took me quite a while to debug what was happening, until I found out the command is really a wrapper whose sole purpose is munging arguments -- and it does it wrong.


Version-Release number of selected component (if applicable):
I am on 3.1.5-1.fc19 but I see the same bug in rawhide.

How reproducible:
Always.

Steps to Reproduce:
1. Be non-root / non-rabbitmq user
2. Run rabbitmqctl status


Actual results:
    Error: could not recognise command
    Usage:
    rabbitmqctl [-n <node>] [-q] <command> [<command options>] 
...

Expected results:
Status of node rabbit@localhost ...
[{pid,1234},...


Additional info:
The warning "Only root or rabbitmq should run" should really be "Only root or rabbitmq must run", as currently it makes it impossible for anyone else.
However, this is not true, as any user *can* run rabbitmq.
Furthermore, users in the rabbitmq group should be able to run management commands, given the correct parameters.
Lastly, the "rabbitmq-plugins" case looks fishy too, as it allows anyone to run the rabbitmq-plugins command, and makes the first line obsolete.

Comment 1 Fedora Admin XMLRPC Client 2014-07-01 17:58:14 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 2 Jaroslav Reznik 2015-03-03 15:15:05 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 3 Tuomo Soini 2016-08-29 08:33:22 UTC
Created attachment 1195211 [details]
Improved and greatly simplified wrapper

Greatly simplified wrapper script which works properly for non-root users too.